From: Muhammad Rizki <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: Alviro Iskandar Setiawan <[email protected]>,
GNU/Weeb Mailing List <[email protected]>
Subject: Re: [PATCH v3 8/9] enum: Add Platform enumeration
Date: Fri, 21 Oct 2022 21:04:56 +0700 [thread overview]
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
On 21/10/2022 21.02, Ammar Faizi wrote:
> On 10/21/22 8:45 PM, Muhammad Rizki wrote:
>> --- /dev/null
>> +++ b/daemon/enums/platform.py
>> @@ -0,0 +1,7 @@
>> +import enum
>> +from .base import EnumBase
>> +
>> +
>> +class Platform(EnumBase):
>> + DISCORD = enum.auto()
>> + TELEGRAM = enum.auto()
>
> Why is this necessary to be auto generated enum?
>
> I don't see any reason of why we should use an extra library
> here. I would just define them manually like:
>
> DISCORD = 1
> TELEGRAM = 2
>
> Thoughts?
>
You want so? But, I really like to use enum library here like everybody
does.
next prev parent reply other threads:[~2022-10-21 14:05 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 13:45 [PATCH v3 0/9] Fix some bugs and add some features Muhammad Rizki
2022-10-21 13:45 ` [PATCH v3 1/9] discord: Add send_text_mail_interaction() Muhammad Rizki
2022-10-21 13:45 ` [PATCH v3 2/9] discord: Add send_patch_mail_interaction() Muhammad Rizki
2022-10-21 13:45 ` [PATCH v3 3/9] discord: Add get lore mail slash command Muhammad Rizki
2022-10-21 13:45 ` [PATCH v3 4/9] atom: Improve remove_patch() Muhammad Rizki
2022-10-21 13:45 ` [PATCH v3 5/9] atom: add manage_payload() Muhammad Rizki
2022-10-21 14:01 ` Ammar Faizi
2022-10-21 14:02 ` Muhammad Rizki
2022-10-21 14:06 ` Ammar Faizi
2022-10-21 14:07 ` Muhammad Rizki
2022-10-21 13:45 ` [PATCH v3 6/9] telegram: Fix get lore command Muhammad Rizki
2022-10-21 13:45 ` [PATCH v3 7/9] atom: Improve extract_body() Muhammad Rizki
2022-10-21 14:34 ` Alviro Iskandar Setiawan
2022-10-21 13:45 ` [PATCH v3 8/9] enum: Add Platform enumeration Muhammad Rizki
2022-10-21 14:02 ` Ammar Faizi
2022-10-21 14:04 ` Muhammad Rizki [this message]
2022-10-21 14:21 ` Ammar Faizi
2022-10-21 14:34 ` Muhammad Rizki
2022-10-21 14:45 ` Ammar Faizi
2022-10-21 14:54 ` Muhammad Rizki
2022-10-21 15:07 ` Ammar Faizi
2022-10-21 15:10 ` Muhammad Rizki
2022-10-21 15:08 ` Ammar Faizi
2022-10-21 15:12 ` Muhammad Rizki
2022-10-21 15:21 ` Ammar Faizi
2022-10-21 15:35 ` Muhammad Rizki
2022-10-21 15:37 ` Ammar Faizi
2022-10-21 15:54 ` Muhammad Rizki
2022-10-21 15:59 ` Ammar Faizi
2022-10-21 15:39 ` Ammar Faizi
2022-10-21 15:45 ` Muhammad Rizki
2022-10-21 15:48 ` Ammar Faizi
2022-10-21 18:29 ` Muhammad Rizki
2022-10-21 18:53 ` Ammar Faizi
2022-10-21 19:05 ` Alviro Iskandar Setiawan
2022-10-21 19:15 ` Ammar Faizi
2022-10-21 19:24 ` Alviro Iskandar Setiawan
2022-10-21 19:07 ` Muhammad Rizki
2022-10-21 17:03 ` Alviro Iskandar Setiawan
2022-10-21 13:45 ` [PATCH v3 9/9] enum: Use the created Platform class enumeration Muhammad Rizki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox