Re: [PATCH v1 2/2] daemon: telegram: Handle MySQL error

[Ammar Faizi <ammarfaizi2@gnuweeb.org>]

On 10/29/22 2:36 AM, Ammar Faizi wrote:
> On 10/29/22 2:34 AM, Ammar Faizi wrote:
>> On 10/29/22 2:29 AM, Alviro Iskandar Setiawan wrote:
>>> On Sat, Oct 29, 2022 at 2:15 AM Muhammad Rizki <kiizuha@gnuweeb.org> wrote:
>>>> Sorry, you mention remove_patch() which function from? Telegram bot
>>>> listener __send_mail() ? if yes, that function is already handled by
>>>> mutex, see it on telegram/mailer/listener.py of __handle_mail(), in line
>>>> 77 it is already hold.
>>>
>>> Is this function only called from one place?
>>> If that's a guarantee, I'm fine with that. But why delete all files,
>>> it's the caller's problem that it doesn't call the function properly.
>>
>> It's also called from daemon/telegram/packages/client.py.
>>
>> That place doesn't hold the mutex anyway.
> 
> Correction, that place may hold or may not hold the mutex, depending
> where they are called. Another place that calls the remove_patch() is
> 
>     daemon/telegram/packages/plugins/commands/scrape.py
> 
> This one always doesn't hold the mutex.

I think deleting all files doesn't make so much sense to me.

Just delete the specific created file only. Why you can't do that?
Rizki, any comment?

-- 
Ammar Faizi