From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_SAFE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Authentication-Results: server-vie001.gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=tXe7NwO+; dkim-atps=neutral Received: by server-vie001.gnuweeb.org (Postfix, from userid 1000) id 0F1222109A97; Wed, 16 Jul 2025 14:30:08 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.166.179; helo=mail-il1-f179.google.com; envelope-from=axboe@kernel.dk; receiver= Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by server-vie001.gnuweeb.org (Postfix) with ESMTPS id A4A182109A94 for ; Wed, 16 Jul 2025 14:30:07 +0000 (UTC) Received: by mail-il1-f179.google.com with SMTP id e9e14a558f8ab-3df2f937370so25790325ab.3 for ; Wed, 16 Jul 2025 07:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1752676206; x=1753281006; darn=vger.gnuweeb.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/Uojjm6fcLZ+mUddp83QrZxw9M8qmMMJaZaJ4O0EjFU=; b=tXe7NwO+kJ0iLCc0ahEQHpGlzovdyWJmx0RGXCApzDpFO6agjIC3GVmXDGnRA6nGvk MslumdJCaAUnlRTO0Tbi9LzJHELzO4mLJDdTCjCdJ/RLfd1pQ/S+Y3o0az28Zy+M0sgx viD3w1SdR9otpNs3N5l9lXuIKphI8cAEmyxukE6xX7HJ8DSzvs0MWviLWLZ4vdU40Lh4 2u2z0k/R1BvmbZ+yV48LerLZvSJwREvhzmOCWGPPkju6M081hw6qoFoyieQ+cuuFE+vt o37k9TIO2tcrBjNNvwpobkoRKjtyhoris/a5X1fs7qiMeuxXelWlzbC5YVQt5c6OKVue 47hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752676206; x=1753281006; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/Uojjm6fcLZ+mUddp83QrZxw9M8qmMMJaZaJ4O0EjFU=; b=QqqlOTOlzyDtLckKiYPAv6d+VOiU8kxdQX9U7MsZ7ECXWeEIrHPqij83IrNM5y4YOb JZbG8LmKObV1DV4tnXu0bCs8kLKtqhD+4y7s23/XuM2JbHYHD5lK9Ano4GE0YU0YipRc wbxqKoxKlDPRyE5HEJ7W/8lEfrr3NVNZPfP+l/iXZ2IlhUkXtddU1PgFMJJo0UJCJ2wB Zdk3h+L6bxjKgRhfmlJF2rVaMbzcNPLYkzh6jXgUZdwarg+fIZ+Yi004C4Bb2V4pAyJB KTGC7+aiP8gcNGgd77iYE9ytwVTFW0Quz/KWDJzqZ/FKV/OHlxPhwRPqblD8Wn4lazG2 y34g== X-Forwarded-Encrypted: i=1; AJvYcCX2gEzVuyVuOjZNvvjWMwLd30fZ6Vo5i1xvTV5AzTTINfNeBFMbDV0mGNix1acSrBnOfNb1@vger.gnuweeb.org X-Gm-Message-State: AOJu0YzkipQc3eMcme9TT8yIJl6H75httCJ7iT4MGZ7eDC9GLqYYDUHe 1bquN+4JojFOPqXmUpk8E5X+EMHRyVkSrEOkvQABA1YXY722hTwiwJOmKTygnGn0L18= X-Gm-Gg: ASbGnctvFRREDaBNGnWJMOu9IGpRz8vvqC9f5eQu7e5HaeI6ISej4lmcOjADjOoczxS mPFcRBe6eY4ZKcQVQV4f3zCVp4UV4K4bOg6IPZsoe5fnQVUA9HlKhT1cVC7qNdJg9JJ1D8kntIz ORIuNi89SHtbKIBF4cIqCtNM94Poh7Jq5vd6W9ydZpYl5GJ8tD0Xacr5pgnpwChXx+eeSUvmXSv rx5ToxzBaotY4Ms9n3wW54dF6fqhbPpIL9uGH3PnlMMOOuW0AG3LKyK22a8viHFpdIKXBwlkBqf GJbQLtywJjA/hQMggJtAm+/pP3gW18MMkBmGuszmk8Ru0UeZXO1fPiDAViJ2B6Zr/iAs9q+tcMv kGdpH4c0h3JCprGhxcHo= X-Google-Smtp-Source: AGHT+IH+jLRGEsW4dtjrdZr5d6r5MlS0/wxSW+OlnfF/Bx4B5TKy4HEdvsg+u/BOVaab0R+9o6M71g== X-Received: by 2002:a05:6e02:4508:20b0:3df:4046:93a9 with SMTP id e9e14a558f8ab-3e282300e22mr24807975ab.5.1752676205462; Wed, 16 Jul 2025 07:30:05 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-50556973079sm3091349173.63.2025.07.16.07.30.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Jul 2025 07:30:04 -0700 (PDT) Message-ID: <9df85c99-4f2d-4d12-875f-ce68e781c107@kernel.dk> Date: Wed, 16 Jul 2025 08:30:04 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH liburing v2 0/3] Bring back `CONFIG_HAVE_MEMFD_CREATE` to fix Android build error To: Alviro Iskandar Setiawan Cc: Ammar Faizi , GNU/Weeb Mailing List , Linux Kernel Mailing List , io-uring Mailing List References: <20250716004402.3902648-1-alviro.iskandar@gnuweeb.org> <3b28fddb-2171-4f2f-9729-0c0ed14d20cc@kernel.dk> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: On 7/16/25 8:28 AM, Alviro Iskandar Setiawan wrote: > On Wed, Jul 16, 2025 at 7:41?PM Jens Axboe wrote: >> For patch 1, maybe just bring back the configure test and not bother >> with a revert style commit? There is nothing in test/ that uses >> memfd_create, so there's no point bringing it back in there. > > Ah yea. That'd be easier. I'll copy the configure part instead of > modifying the git revert result ? Exactly, just make it that single patch. >> IOW, patch 2 can be dropped, as it's really just dropping bits >> that patch 1 re-added for some reason. >> >> All that's needed is to add it to the examples/ helpers. If it's >> needed for test/ later, then it can get added at that time. >> >> All of that to say, I'd just add the configure bit and the examples/ >> helper in a single patch and not worry about test/ at all. > > Understandable. I'll send a v3 revision shortly. Thanks! -- Jens Axboe