From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: * X-Spam-Status: No, score=1.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.6 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B912C433FE for ; Thu, 10 Mar 2022 12:25:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241980AbiCJM0a (ORCPT ); Thu, 10 Mar 2022 07:26:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237763AbiCJM0a (ORCPT ); Thu, 10 Mar 2022 07:26:30 -0500 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DEF4148665; Thu, 10 Mar 2022 04:25:29 -0800 (PST) Received: by mail-lj1-x235.google.com with SMTP id q5so7426496ljb.11; Thu, 10 Mar 2022 04:25:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5+S/19T7z8CqGJz5OOOtlJzN3mZfdNMJ1w7/PO7Phfo=; b=nk+hj7MWuNgvAdNzdtNd0A6lvaKaHdkrpdRyvFi/F2c/bBXMOB8M701YRllaDH9Wvx +Tb+/eUbI+ukdykKaWWDDrgKeuoEUjq/eZ9SEcevo2tfDRht4CVXcDEGBnYf+TuIXmSj eyzKE/PcjKx2SuqxKqHK6AGpoKLtjonkXc7NjULd2qCWbOywtgdWla2nasjfcJG+xcJ3 m2tzOh4XC1zi4YO/fe4NJ4kPU3al8dOJN/ylDqRMbXwRCNF0NVTNz3O6UN/nrNWYeF5J yhIrolM2pNKobaZ7OyNw/RxpvHQNLPecNi5i9embbAU3QhZ+aLLum+4etw/AO6NBS6qf 48nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5+S/19T7z8CqGJz5OOOtlJzN3mZfdNMJ1w7/PO7Phfo=; b=xuYl5uo7p2YsL4AD9Hd/32oNywp35QD8zU1ZqgvRVQutrFRrMl5+DfBjq4LOlfpz2B Z4nwX8BLlsZGE9Nk8GPqESD64IsBQkkuyvj3mFjYTyrEG0OvvyfxjZVz2o84TLt7Cb+O kYw9unjXVDQjjO4VtEk8WGOk6Ys1jx5WvyjDRErUdIBINcN7FFKXgoAGcQQXgH+wT5la KnixR5k7mlxlXCUQZxcJUflYnrASGb01tqbt1tU8nEKqXoqIkmGRX+QDXHo+341h3DmD rL25ybIWOjwZa9LqV5zQGbjXoHhH8PSD5MC2O3CU1k6UUgycNWS7+wJ9MP4c7ptXLRAY V8BA== X-Gm-Message-State: AOAM533stf2NDPZNtliz1We1ZIySlJ9Wk0zPoiTfQRrmSWB+gboUJu+n +uDVwAAafa7Hp+TpGAusN2glYXZPhPeOW76T1kJEFBO9GeY= X-Google-Smtp-Source: ABdhPJzsG6bp2WM29pnDrFfkLztteUacWjOolraWs5IwAxOIBsy7dmQHWUuyglX9BAPiJLNIBiwnRBUE+lYZxUkRT4w= X-Received: by 2002:a05:651c:b07:b0:247:e06d:8943 with SMTP id b7-20020a05651c0b0700b00247e06d8943mr2736349ljr.426.1646915127520; Thu, 10 Mar 2022 04:25:27 -0800 (PST) MIME-Version: 1.0 References: <20220308152105.309618-1-joshi.k@samsung.com> <20220308152105.309618-12-joshi.k@samsung.com> <20220310083503.GE26614@lst.de> In-Reply-To: <20220310083503.GE26614@lst.de> From: Kanchan Joshi Date: Thu, 10 Mar 2022 17:55:02 +0530 Message-ID: Subject: Re: [PATCH 11/17] block: factor out helper for bio allocation from cache To: Christoph Hellwig Cc: Kanchan Joshi , Jens Axboe , Keith Busch , Pavel Begunkov , io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, sbates@raithlin.com, logang@deltatee.com, Pankaj Raghav , =?UTF-8?Q?Javier_Gonz=C3=A1lez?= , Luis Chamberlain , Adam Manzanares , Anuj Gupta Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Thu, Mar 10, 2022 at 2:05 PM Christoph Hellwig wrote: > > On Tue, Mar 08, 2022 at 08:50:59PM +0530, Kanchan Joshi wrote: > > +struct bio *bio_alloc_kiocb(struct kiocb *kiocb, unsigned short nr_vecs, > > + struct bio_set *bs) > > +{ > > + if (!(kiocb->ki_flags & IOCB_ALLOC_CACHE)) > > + return bio_alloc_bioset(GFP_KERNEL, nr_vecs, bs); > > + > > + return bio_from_cache(nr_vecs, bs); > > +} > > EXPORT_SYMBOL_GPL(bio_alloc_kiocb); > > If we go down this route we might want to just kill the bio_alloc_kiocb > wrapper. Fine, will kill that in v2.