From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1754398096; bh=rYH1rB9ixgH4oJisv6LSpLoUDaSDf2EeNeos7WkMUpQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=Ah2XjblnudVKDsUyWYRWg1MXn5ifbOOXBd3SRTZGxOAJNK51SkFHCVVRESSwgVrd+ zmLm5Ofv9XTALeZ+wX7WsFQo96DIRh7s6FNqzhmlM/nFCGSlxIckuqwMCrwVKvozUy n1CzaOfzm3owHhX9OvDJU4xX35bQwbcUPBXEYymAAP8Izh1D2FLqem4WkMcHL2R45r GCe69uoUj8otokXsYbye+G5OxnGqkNf2HsC0jzuu+jjgu9as4S/OyiV4YmU8KTckID BcD8E7/LE0jagkpxPBM8e5foSSMAvCJ6o1K00NahIAgV+E8SFQuqehJGvFXcGOBbhk 0KW8gcy1WaOKg== Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 575463128059 for ; Tue, 5 Aug 2025 12:48:16 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-55ba26abd62so2546060e87.1 for ; Tue, 05 Aug 2025 05:48:16 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXwy9623vhxcdEWxFxuwlKgiUKMAUYm4ijcnmB/yFKcRW1kZEm1p1gcQ3zatjMUGj5nsFlX@vger.gnuweeb.org X-Gm-Message-State: AOJu0Yzh+oVcLpLJySsLmd2Y1CrueJls0RSYBMCBj6R0ZCDNJTIJETTn G1aj/fnjQ8SZnl9KO5hYmOFyMQ9s6uor7IigUtpI6Zj47TPwOUjV/ertiGuPQykDPJ/Lzll8lGe yOn4Au/u2NZuBxM58hMaVAPWm+2eGUQ4= X-Google-Smtp-Source: AGHT+IHuX0SG5wkQXilBQLSN2/NP/2czWUG2S6UkvX4nIl64mwaGleGT4GJen0Mj7qmfWYmHUonajH5gfhQT1O5mHxo= X-Received: by 2002:a05:6512:304d:b0:55b:8ba4:8e30 with SMTP id 2adb3069b0e04-55b97ba612fmr4148047e87.51.1754398095673; Tue, 05 Aug 2025 05:48:15 -0700 (PDT) MIME-Version: 1.0 References: <20250805064933.109080-1-reyuki@gnuweeb.org> <20250805064933.109080-7-reyuki@gnuweeb.org> In-Reply-To: From: Ahmad Gani Date: Tue, 5 Aug 2025 19:47:38 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXyiRZgW1tjlI1G7sOK99-FndcVdE2a1GU5N5KC5CMc1le_adwczb7ok8DY Message-ID: Subject: Re: [PATCH gwproxy v3 6/9] dnsparser: Fix serialize_answ function To: Ammar Faizi Cc: Alviro Iskandar Setiawan , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Tue, Aug 5, 2025 at 4:26=E2=80=AFPM Ammar Faizi wrote: > On Tue, Aug 05, 2025 at 01:49:26PM +0700, Ahmad Gani wrote: > > This changes ensure memory read access is always valid. It fixes a logi= c > > bug in serialize_answ that can lead to a memory error: invalid read. > > Don't add a new patch that fixes a bug to your previous patch in the same > series. Each patch, when applied, must not introduce a known bug. This > hurts bisectability. This fix should be squashed into the buggy patch. Sorry, I haven't done bisecting in Git before, so I'm not aware of that. By the way, I have another question. If a patch appears to be bug-free and gets applied but later turns out to have a bug, will the fix be included in the problematic commit found by git bisect or added as a new commit that refers to the original one? I assume the latter makes more sense, since it preserves the commit history for other contributors. -- Ahmad Gani