Re: [PATCH gwproxy v8 2/2] gwproxy: refactor code base to add experimental raw DNS backend

[Ahmad Gani <reyuki@gnuweeb.org>]

On Sat, Sep 6, 2025 at 11:32 AM Ahmad Gani wrote:
> > On Fri, Aug 29, 2025 at 2:56 PM Ahmad Gani wrote:
> >> +void cp_nsaddr(struct gwp_dns_ctx *ctx, struct gwp_sockaddr *addr, uint8_t *addrlen)
> >> +{
> >> + *addr = ctx->ns_addr;
> >> + *addrlen = ctx->ns_addrlen;
> >> +}
> >
> > Why is this exposed globally? I don't think it's worth a function
> > call. Better be inlined.
>
> I can't access members of the gwp_dns_ctx struct directly from another
> file, as it seems to be treated as an opaque pointer outside of dns.c. If
> I make it an inline function, it would only be accessible within dns.c.
> Should I move the full declaration of the struct to the header file?

Oh, wait—I just realized you were talking about the inline keyword, not
static. My previous reply was unrelated; I misunderstood. In that case,
I'll add the inline keyword if it's not worth a function call.

--
Ahmad Gani