From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1757139481; bh=+cYgJfSu8QeBmZmKvOeVZSvLddjaY6yEGw/patnGGXI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=AeV+0kosX7OHqY1eIufKxOY7PfneZs26grXkF2cT83fDZSIQpjF9tcGVYEJjolWlp sSEfU4G69skAPjtGdgDuvzSURe5tVffYj+CMUDhcUJGfFHxbgcynFvgC0D/qcPeOod /skZHYoYM4OZLtuk7nLS7m6AjqSo9GnmIObW2PiPB40Z7JALkEpRcyPOacCefmNXKn 9eR1jTw7XQOVptVtoU+8Ih5dmxgc3PkRc5qoJgvbCZqHEb8x4dybTC7VFMno+agtCg bRQzSzpBYfgI2/OtUikkLdxF5Ao8DsWShZPjzW8BX7TXZxmBsk7y3TE0Xm+Y1xTzZ9 +VwfYrLd2hcww== Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 0F2A43127A9C for ; Sat, 6 Sep 2025 06:18:01 +0000 (UTC) Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-336cdca667aso22312131fa.0 for ; Fri, 05 Sep 2025 23:18:01 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUjaYJDw6a/8pLSvdFBZel8Sb0QygMcMjk3UseCPEOvC5hnGw/uFqX6wEqlPyyy6oC/aGXR@vger.gnuweeb.org X-Gm-Message-State: AOJu0YwFFnG20MqpnpToRXBCetF5R4aIqZpMHkf079ddiUah9U72IIG0 SuqwhTQLf/+zzcrXTJV4Uq16ILpUPMnglOgGsyctx6uuHrnYs3azvRN4LRmDmXswS0ppAO9UZy9 x/VNJD5yYsiUfwuvy79A8tMKgT8I+9NE= X-Google-Smtp-Source: AGHT+IH0COHRaPx+xJCDSfbzU40h+OFtRgr5z8RCYpvGin+Mwb49roCHEfoal3Cl1CzmNse8NPEBrUao1undyp0HPbA= X-Received: by 2002:a05:651c:1109:20b0:338:603:307c with SMTP id 38308e7fff4ca-33b52891174mr2926851fa.26.1757139480441; Fri, 05 Sep 2025 23:18:00 -0700 (PDT) MIME-Version: 1.0 References: <20250829075557.598176-1-reyuki@gnuweeb.org> <20250829075557.598176-3-reyuki@gnuweeb.org> In-Reply-To: From: Ahmad Gani Date: Sat, 6 Sep 2025 13:17:24 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXy0W67l0DcFtEvukYH2q5HAT_JyWHitTVJ0mDEJTAFO47xwQTW0HvE6hUw Message-ID: Subject: Re: [PATCH gwproxy v8 2/2] gwproxy: refactor code base to add experimental raw DNS backend To: Alviro Iskandar Setiawan Cc: Ammar Faizi , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Sat, Sep 6, 2025 at 11:32=E2=80=AFAM Ahmad Gani wrote: > > On Fri, Aug 29, 2025 at 2:56 PM Ahmad Gani wrote: > >> +void cp_nsaddr(struct gwp_dns_ctx *ctx, struct gwp_sockaddr *addr, ui= nt8_t *addrlen) > >> +{ > >> + *addr =3D ctx->ns_addr; > >> + *addrlen =3D ctx->ns_addrlen; > >> +} > > > > Why is this exposed globally? I don't think it's worth a function > > call. Better be inlined. > > I can't access members of the gwp_dns_ctx struct directly from another > file, as it seems to be treated as an opaque pointer outside of dns.c. If > I make it an inline function, it would only be accessible within dns.c. > Should I move the full declaration of the struct to the header file? Oh, wait=E2=80=94I just realized you were talking about the inline keyword,= not static. My previous reply was unrelated; I misunderstood. In that case, I'll add the inline keyword if it's not worth a function call. -- Ahmad Gani