From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <reyuki@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS,
	URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no
	version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1755405316;
	bh=0YLc5YanoCkdG5j+Q4Ra2PoZW7iRQDyall2LIhtX9l0=;
	h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
	 To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From:
	 Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date:
	 Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type:
	 Content-Transfer-Encoding;
	b=j9PYYxcXKdeuM/BvVkHhX2/IdApO5Z7FOAV8PLBKTQwpgcOVh82tcBfTW5YMVc91m
	 Nld0CDz6wnb3DDtC3M+MpB6AgdWDbpjbzwwTt8Hj94SMwAAKgsPrak436hGSHCJgOX
	 S6qG9jNtHwHFaRaSuS6O7ZYxdhOWj0dYHbWnPb3KvvPgo7zCz0XyJLG45h+QST2BPH
	 w70X46t0sLwbVLqTCKZU8YEKRdEfRrXeswsvvb+1jZsufdWIJh0u/J9seG/fIWIicW
	 Q/W5pRN1H8RpUVhyXEDGnXRxI1QJ5Iy+whhxis2JoLL/zvNdwefedfmR/QL7bpT5v7
	 KN2zmFdramh4Q==
Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 3B30C3127E59
	for <gwml@vger.gnuweeb.org>; Sun, 17 Aug 2025 04:35:16 +0000 (UTC)
Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-55ce4d3b746so3677457e87.1
        for <gwml@vger.gnuweeb.org>; Sat, 16 Aug 2025 21:35:16 -0700 (PDT)
X-Forwarded-Encrypted: i=1; AJvYcCXOGC0L1O3GoTHhcWIdXwS7NbGif01oZQQl97ytbketeo7t+BxETb+cL4Xd94J5Cv4EV/qV@vger.gnuweeb.org
X-Gm-Message-State: AOJu0YwCXU4sYq7jgMwcNDQ8dxUWNDCEXc6jfvfK/B7gLWjZrPp60u1w
	FQtgCFayMgCGEk0lpsXSVkfGRpP17pS+jPu/46pRibgzmu4f+qTnvqLDJ1KHAFU4lefdUsfZp1U
	7eXXAuU6gH/hDJOlc+qfAYSbQv+G/nXw=
X-Google-Smtp-Source: AGHT+IHQznOPP41eUP49A4FOc6EjFxF66ou5G1RFk30FhCnvfvT1fAWP9B9+qz+Z1cQriV3yISaxqBStypOePfvjLs8=
X-Received: by 2002:a05:6512:2115:b0:55b:79e8:bf83 with SMTP id
 2adb3069b0e04-55ce62bd9bbmr2428109e87.14.1755405315598; Sat, 16 Aug 2025
 21:35:15 -0700 (PDT)
MIME-Version: 1.0
References: <20250817031621.81090-1-reyuki@gnuweeb.org> <CAOG64qOiHK8K18jEzV6vgoWt4KT1U7iLczNB-D_=dCdiJUcmoQ@mail.gmail.com>
In-Reply-To: <CAOG64qOiHK8K18jEzV6vgoWt4KT1U7iLczNB-D_=dCdiJUcmoQ@mail.gmail.com>
From: Ahmad Gani <reyuki@gnuweeb.org>
Date: Sun, 17 Aug 2025 11:34:39 +0700
X-Gmail-Original-Message-ID: <CAADvAgo5pAnUhKHWq-DN2dJ0SyKm5i3E9_sw+3wBN_F3GY0nEw@mail.gmail.com>
X-Gm-Features: Ac12FXwTi1dPkHeK5FpdmF942RopTHcM_73x1CAmBnoNRPpZRNyzeSLKAe3Yl6U
Message-ID: <CAADvAgo5pAnUhKHWq-DN2dJ0SyKm5i3E9_sw+3wBN_F3GY0nEw@mail.gmail.com>
Subject: Re: [PATCH gwproxy v0] epoll: Improve log readability and efficiency
To: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>, "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <gwml.vger.gnuweeb.org>

On Sun, Aug 17, 2025 at 11:24=E2=80=AFAM Alviro Iskandar Setiawan wrote:
> NAK.
>
> If gwp_alloc_conn_pair() fails, you're leaking a TCP fd from
> accept4(). After your changes, no one holds the returned fd except
> that local variable.

Ah, you're right=E2=80=94I forgot to close the fd when gwp_alloc_conn_pair(=
) fails.

I'll add a close(fd) in that path and send a v2 PATCH (and I'll use v1
instead of v0 for the subject next time).

--
Ahmad Gani