From: Ahmad Gani <reyuki@gnuweeb.org>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
"GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v0] epoll: Improve log readability and efficiency
Date: Sun, 17 Aug 2025 11:56:53 +0700 [thread overview]
Message-ID: <CAADvAgo8GnN4DQftAVsdSa8q33f9=npESp_CX=yCSsvBn0BFuw@mail.gmail.com> (raw)
In-Reply-To: <CAADvAgoN5fcuX3M+_29MpOz-kD_ENV_5ithWWxmNU5MuWiX+BQ@mail.gmail.com>
On Sun, Aug 17, 2025 at 11:49 AM Ahmad Gani <reyuki@gnuweeb.org> wrote:
> On Sun, Aug 17, 2025 at 11:37 AM Ammar Faizi wrote:
> > On Sun, Aug 17, 2025 at 11:34:39AM +0700, Ahmad Gani wrote:
> > > Ah, you're right—I forgot to close the fd when gwp_alloc_conn_pair() fails.
> > >
> > > I'll add a close(fd) in that path and send a v2 PATCH (and I'll use v1
> > > instead of v0 for the subject next time).
> >
> > Don't use close(), use __sys_close().
>
> Understood, I'll switch to __sys_close().
>
> By the way, I wonder why GWP_CONN_FLAG_NO_CLOSE_FD exists? Can you explain
> the use cases for such a thing to exist?
>
> Wouldn't it cause a file descriptor leak too?
Oh, it is only used in the io_uring system.
--
Ahmad Gani
next prev parent reply other threads:[~2025-08-17 4:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-17 3:16 [PATCH gwproxy v0] epoll: Improve log readability and efficiency Ahmad Gani
2025-08-17 4:24 ` Alviro Iskandar Setiawan
2025-08-17 4:34 ` Ahmad Gani
2025-08-17 4:37 ` Ammar Faizi
2025-08-17 4:49 ` Ahmad Gani
2025-08-17 4:56 ` Ahmad Gani [this message]
2025-08-17 4:57 ` Ammar Faizi
2025-08-17 5:02 ` Ahmad Gani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAADvAgo8GnN4DQftAVsdSa8q33f9=npESp_CX=yCSsvBn0BFuw@mail.gmail.com' \
--to=reyuki@gnuweeb.org \
--cc=alviro.iskandar@gnuweeb.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox