From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1755406650; bh=zJoFkep8RW8/CAVSHz3G4ROpkIZSsaUHcPkLs+67zlQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=ktsOif+fiy5UJNFZrsWhe0CV2MKUUGhO6mRmvFCpL3IzR+ZKu/6oUp72YHjrJlbzz usuVgX7R2B7BJxQgT4g/LMaOOdxvyXk3v5XaynFxoFxQ1k8y6zoy18q8i/V/1ErL8n rt2nG0zM0Ea6VXSrOBz35VEn1sfnThwuKr6gT68/7Fgey8JeiwPh3cvxJno4k35GvT x7JXUnw8wi3/cjTedXzE3zNe+1dYjHOuntME4JlIIgkE12lZKO9L7hosfs+8KBjrtw P8DqSmmL3o0pEMaY02hEmOXt9x47dhNMIe9uQqoe4jcuVD22zD2GXPee8ILvG7y90q VAK6va1uypRLQ== Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 8F8FD3127EA2 for ; Sun, 17 Aug 2025 04:57:30 +0000 (UTC) Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-333f8d24c6fso27355401fa.0 for ; Sat, 16 Aug 2025 21:57:30 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUCn5bjINTwbZHOfnPuBbAl5pTHELIglSbof/N2oj9OpIPMwF4akjOffBPaLwJmocgdJCaL@vger.gnuweeb.org X-Gm-Message-State: AOJu0Yz5S0c4qLuiBTo2q5XbAM0sWLMgSGauk09q1n2D4n8TzPIHOqKY +yyuWhx1CeK6N7/HTpMNbXCNtgs/1FL8zkPLmwuT43p/XGVOHAjMqAR74hpyzBypa3r4faSLJ9F f0bWrmPcVUqlgNFFo2/VEaccTw2hh8H8= X-Google-Smtp-Source: AGHT+IFlyOj231P6RQ34m3RtdpIuvuzxInshPhrysMhhfmiICIXYGQr1+AFwZ4gbN7gBnSFPyB7EIoyUL9Ne5lWDvl0= X-Received: by 2002:a05:651c:2208:b0:32f:1c0f:fb73 with SMTP id 38308e7fff4ca-334099bb9e9mr25209441fa.36.1755406649984; Sat, 16 Aug 2025 21:57:29 -0700 (PDT) MIME-Version: 1.0 References: <20250817031621.81090-1-reyuki@gnuweeb.org> <20250817043750.GA545393-ammarfaizi2@gnuweeb.org> In-Reply-To: From: Ahmad Gani Date: Sun, 17 Aug 2025 11:56:53 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXwQ7vrHyJb-LZowB3Fp8hS34kLkAFOvfinbuGhTbcNULDMchDv0EG4F9wQ Message-ID: Subject: Re: [PATCH gwproxy v0] epoll: Improve log readability and efficiency To: Ammar Faizi Cc: Alviro Iskandar Setiawan , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Sun, Aug 17, 2025 at 11:49=E2=80=AFAM Ahmad Gani wr= ote: > On Sun, Aug 17, 2025 at 11:37=E2=80=AFAM Ammar Faizi wrote: > > On Sun, Aug 17, 2025 at 11:34:39AM +0700, Ahmad Gani wrote: > > > Ah, you're right=E2=80=94I forgot to close the fd when gwp_alloc_conn= _pair() fails. > > > > > > I'll add a close(fd) in that path and send a v2 PATCH (and I'll use v= 1 > > > instead of v0 for the subject next time). > > > > Don't use close(), use __sys_close(). > > Understood, I'll switch to __sys_close(). > > By the way, I wonder why GWP_CONN_FLAG_NO_CLOSE_FD exists? Can you explai= n > the use cases for such a thing to exist? > > Wouldn't it cause a file descriptor leak too? Oh, it is only used in the io_uring system. -- Ahmad Gani