From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1754475663; bh=bt37/5gpfgkGlGbptl5K4QKOnDxCJ/FZ+Rf2HLXjWbA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=iGlyJg2YXuJNCyLoB1xwH++Mblx/BS1C6efbNAr6Nsna9FyXSVWf1NI7+1dlUrPbM McsK1W+5n+QMumYq3G9kibSZK9K9CeoCvSac05EUv/hsXF9Io1/GH9v4dN+vMo1rSL Pv5reH2E0n6/Vg9F6/1U5t5XAVrfutVmfawn0bR4CqZ+xmG4o7lTUV7JzneUik1Al5 hL5gvG9I7m7iXMOVp/h0Fy+MS3+KnX/RwJCZbFggx0895p5QA6Ru7ny6AXQbLZ7dAd vve78h9QuGFCcYbW3RMIxv9T1EFFPfkmOxWzNgqLt8GtwJXAs7LSy/QcuZzcFNHwz9 Xj3UaPGWqVrKg== Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 998AC3127B3F for ; Wed, 6 Aug 2025 10:21:03 +0000 (UTC) Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-332590cc87fso33022661fa.3 for ; Wed, 06 Aug 2025 03:21:03 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWbzK8FpUFvlgD8UFjeqV2SPbAgh45f/5dBRR86uedasc8z+QIAIGz14a2hjRRfAojvu05t@vger.gnuweeb.org X-Gm-Message-State: AOJu0Yyp6UMksFp+HA4CUM8XAiRwDVaxvc4MrscTjI50Q+O41TvC+4Zl Qln9XmHrnvFEAhQQ+NmQEMDIVYSH21yZLm5wFm1J6e0LzhJurlpUKwg+eCAO+3GaN0wr7+F8atC d+Jybr4vqkAMyFVb1+Il1vUSfenpurMw= X-Google-Smtp-Source: AGHT+IFpTBtLKPeEkIQeHI2mJEpHLGelgeLdo6wE7Rta6xZcMuzFzIoEASU6FZl3B2R0WQIERDnXw6qcV+GP30TTobk= X-Received: by 2002:a05:651c:1303:b0:332:4da1:8ec4 with SMTP id 38308e7fff4ca-33381409611mr5622431fa.29.1754475662977; Wed, 06 Aug 2025 03:21:02 -0700 (PDT) MIME-Version: 1.0 References: <20250806035727.216702-1-reyuki@gnuweeb.org> <20250806035727.216702-6-reyuki@gnuweeb.org> In-Reply-To: From: Ahmad Gani Date: Wed, 6 Aug 2025 17:20:26 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXxR0niho7ievECLZtOd7K4vab6bYxshxMJujPoO_Vl3NVnt-RCybHTXWlA Message-ID: Subject: Re: [PATCH gwproxy v4 5/6] dnsparser: Transaction id creation is delegated to caller To: Alviro Iskandar Setiawan Cc: Ammar Faizi , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Wed, Aug 6, 2025 at 1:28=E2=80=AFPM Alviro Iskandar Setiawan wrote: > On Wed, Aug 6, 2025 at 10:57=E2=80=AFAM Ahmad Gani wrote: > > --- a/src/gwproxy/dnsparser.c > > +++ b/src/gwproxy/dnsparser.c > > @@ -65,9 +65,9 @@ static ssize_t calculate_question_len(uint8_t *in, si= ze_t in_len) > > > > int serialize_answ(uint16_t txid, uint8_t *in, size_t in_len, gwdns_an= sw_data *out) > > { > > - size_t idx; > > gwdns_header_pkt *hdr; > > uint16_t raw_flags; > > + size_t idx; > > int ret; > > Don't yield unrelated changes. Something like this, variable > reordering, should be squashed. It has no relevance with "Transaction > id creation is delegated to caller". Err.. How do you usually clean up commits like this? I accidentally amended the changes to the current commit, and splitting it manually without a diff seems like a nightmare. Is there a way to make splitting a patch easier? -- Ahmad Gani