From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1755406190; bh=AeATqQ/n4RiZG4zdkx+lsbYf7C2zBiGp0RaY8ebGngg=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=nq5D16GAvh+/q3BLT3jVTHAQxJKIp9ZmWkIMFWhuVKlSWig26TjZ/DOm7PBXtZsNw wJC5Oq/46sAQkQJcvEJeSxdS4iH0vdRoz3lTl2Cg0vD/oMLOZ5fpadC3p66OeJIayD AcuV/H0QqOkhy1dC+WLQO/qw+Lu6bRrTjf1/1g8LYB2yeiLsP+/CVgzarFUUNabCNn P2Rxk+LN51fRMxsZq5MEG61Tk07uu4gPLbaEQYX+1rjP3EJEa3G3PjmZD558EX1kWQ FfM7FX6a+196yoKXSve9icaAAT7Y63T7pjKgzCpvHrYbNAASmNLY9jGpeA/q6AQOdX 0GnAzOgAV7ATA== Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 909983127E9F for ; Sun, 17 Aug 2025 04:49:50 +0000 (UTC) Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-333f8ef8483so24419551fa.1 for ; Sat, 16 Aug 2025 21:49:50 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUeHYBVQTiU1rijyQS3yD3IlSAZgeIXKoeD1mOK6jc1om427gMzfH/pt6kCJT4+4ofah7zk@vger.gnuweeb.org X-Gm-Message-State: AOJu0YyKnRXFSJ87a4M4fvnl6qghUTKHhcrhi6xliIrdRqGZ/iyEEqxG HMFo/1ymmzqVwRMZlsIATgzOPDiCF4UYZ7otlUGFEGnd5vPkzztV88owBFeyjZ1QP/ty2jBYi6p oSZCPX0vfN/XzEN//fZRaWuYE9jqURPk= X-Google-Smtp-Source: AGHT+IGv4v8PfflzT75HHzv1YpwqACzw400kD1BZ8UfRrS1uYq3BfVghwYVlU5mxsnm/LVTXEeQ6VWKSmm8n1s00tdA= X-Received: by 2002:a05:651c:220e:b0:32a:6b23:d3cc with SMTP id 38308e7fff4ca-334099d3052mr19335251fa.25.1755406189888; Sat, 16 Aug 2025 21:49:49 -0700 (PDT) MIME-Version: 1.0 References: <20250817031621.81090-1-reyuki@gnuweeb.org> <20250817043750.GA545393-ammarfaizi2@gnuweeb.org> In-Reply-To: <20250817043750.GA545393-ammarfaizi2@gnuweeb.org> From: Ahmad Gani Date: Sun, 17 Aug 2025 11:49:13 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXyqXMV11tQ2pqy0uajUcDBbikvIFvvupjlMeadA1Os8it4xGRZ_6nWqCbA Message-ID: Subject: Re: [PATCH gwproxy v0] epoll: Improve log readability and efficiency To: Ammar Faizi Cc: Alviro Iskandar Setiawan , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Sun, Aug 17, 2025 at 11:37=E2=80=AFAM Ammar Faizi wrote: > On Sun, Aug 17, 2025 at 11:34:39AM +0700, Ahmad Gani wrote: > > Ah, you're right=E2=80=94I forgot to close the fd when gwp_alloc_conn_p= air() fails. > > > > I'll add a close(fd) in that path and send a v2 PATCH (and I'll use v1 > > instead of v0 for the subject next time). > > Don't use close(), use __sys_close(). Understood, I'll switch to __sys_close(). By the way, I wonder why GWP_CONN_FLAG_NO_CLOSE_FD exists? Can you explain the use cases for such a thing to exist? Wouldn't it cause a file descriptor leak too? -- Ahmad Gani