Re: [PATCH gwproxy v6 00/11] Initial work on integration of DNS parser lib in gwproxy

[Ahmad Gani <reyuki@gnuweeb.org>]

On Fri, Aug 29, 2025 at 5:23 AM Ammar Faizi wrote:
> Stop doing the same mistake again, again, and again. Don't send a patch
> to fix your previous patch. I'll add unnecessary noise for the reviewers
> and clutter the git history.
>
> For example:
>
> - You add various enums in patch #3, but you remove them in patch #4.
>
> - You remove getaddrinfo_a() in patch #6, but you add it again in patch #8.
>
> - You remove the DNS tests in patch #6, but your bring the tests back
>   in patch #9.
>
> There are more patterns like that. Something like that should just
> be f*ck*ng squashed. No need to bomb the list and reviewers with
> unnecessary additions and removals which end up doing nothing because
> your addtions are fully undone by your removals and vice-versa.
>
> You should only send fix-and-revert patches to fix upstream commits,
> not to fix your local commits.

Sorry, I should have clarified and explained it better.

I meant to provide more context and to open a discussion about each commit
in this patch series, not to have the patches applied as-is. But I guess
you're right; if I want to do that I can point to the branch on the GitHub
repository and send a cleaned set of patches.

Now that I understand patch series are intended to be applied, and that
unnecessary context just becomes noise for people who didn't make these
modifications, I will send a cleaned patch series next time.

--
Ahmad Gani