From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1756428917; bh=YcOFExSe58nmAYZlr7oZmwhCLMoixSwHQNvLtFZhJwI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=VSjF/yyzwUPpRMa0inxhJgi1uP4hpsIvg7JvYOq0nujiEc9EWQPVZbFUdks4eswVO KTxaaCJYX6Ap3fVmcGbdIzLkJQUQU7TORce0FX+E4Afc+4DReW9SEXmVCkef93qswx u+gge5UEeBb+3UwHPha6aEmhys4LaoOKGQnS/P0ELWckAVAF28gKa46yE4adAzkTe4 yVKFgHAVGODmHXuWTvvzIlgYhzEzDU0THuDT856Bsz/UGYpZ+oOmLy6lm5QTjxnf6K XmksXvOusUcJPcv4Gkpgs9xv8NFbL4Jp2UVEX7Cm7cuOaYqz0OtA2n/utmcPHkJbdQ iy+YAPFA34LwQ== Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 8BC4C3127F77 for ; Fri, 29 Aug 2025 00:55:17 +0000 (UTC) Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-33667661214so12911811fa.2 for ; Thu, 28 Aug 2025 17:55:17 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCX/8vQURLmJNH/yWp19CI0O8k+i2qrBKkATwMcUYO57DgMQKXlvjmzEctRGPe+Eyf3VywnJ@vger.gnuweeb.org X-Gm-Message-State: AOJu0YxEFYGT+GNLVbvMeRDVtZ0W6+Khv4ZVC2/CmTsWxkt6KgOJsx7h h1vMyucL4R1/JZRuJceS9g863+lZ9IvhxDYjKNPh2+TlT9BygHhzCpamHQy+Nz4QI5kjjZgJXth +yiMgUbci9H8FvrUwfai68+AnVMqQhfM= X-Google-Smtp-Source: AGHT+IE6ZE6mHQfGlnQHjRsDn2kauFqqDn46Kfoym/0angXl8+hXoClISCXML8+pnpMXOvkpmJAoa/KRddYWx0WLyQA= X-Received: by 2002:a2e:a54d:0:b0:336:6be3:2d0b with SMTP id 38308e7fff4ca-3366be3391bmr52489651fa.29.1756428916933; Thu, 28 Aug 2025 17:55:16 -0700 (PDT) MIME-Version: 1.0 References: <20250828143444.540247-1-reyuki@gnuweeb.org> <20250828222303.GA540452-ammarfaizi2@gnuweeb.org> In-Reply-To: <20250828222303.GA540452-ammarfaizi2@gnuweeb.org> From: Ahmad Gani Date: Fri, 29 Aug 2025 07:54:40 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXw3rkWL7Yc3cn1F3PDrINtxRObUBy353DyYgiZPLV3PjA4kwoW0oO0hFCE Message-ID: Subject: Re: [PATCH gwproxy v6 00/11] Initial work on integration of DNS parser lib in gwproxy To: Ammar Faizi Cc: Alviro Iskandar Setiawan , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Fri, Aug 29, 2025 at 5:23=E2=80=AFAM Ammar Faizi wrote: > Stop doing the same mistake again, again, and again. Don't send a patch > to fix your previous patch. I'll add unnecessary noise for the reviewers > and clutter the git history. > > For example: > > - You add various enums in patch #3, but you remove them in patch #4. > > - You remove getaddrinfo_a() in patch #6, but you add it again in patch #= 8. > > - You remove the DNS tests in patch #6, but your bring the tests back > in patch #9. > > There are more patterns like that. Something like that should just > be f*ck*ng squashed. No need to bomb the list and reviewers with > unnecessary additions and removals which end up doing nothing because > your addtions are fully undone by your removals and vice-versa. > > You should only send fix-and-revert patches to fix upstream commits, > not to fix your local commits. Sorry, I should have clarified and explained it better. I meant to provide more context and to open a discussion about each commit in this patch series, not to have the patches applied as-is. But I guess you're right; if I want to do that I can point to the branch on the GitHub repository and send a cleaned set of patches. Now that I understand patch series are intended to be applied, and that unnecessary context just becomes noise for people who didn't make these modifications, I will send a cleaned patch series next time. -- Ahmad Gani