Re: [PATCH gwproxy v11 4/6] gwproxy: Refactor code base to add experimental raw DNS backend

[Ahmad Gani <reyuki@gnuweeb.org>]

On Sun, Sep 14, 2025 at 7:14 PM Ammar Faizi wrote:
> On Sun, Sep 14, 2025 at 12:09:38PM +0700, Ahmad Gani wrote:
> > Use fallback mechanism for raw DNS
> > If *_PREFER_* is used in the restyp, the raw DNS backend will attempt to
> > retry DNS query with different address family if it failed.
> >
> > Add new cmdline arguments:
> > - raw-dns: enables the experimental raw DNS feature
> > - dns-server: sets the default DNS server
> > - session-map-cap: sets the default capacity for the session_map and stack.arr arrays
> >
> > The struct gwp_dns_ctx is now exported due to the need for accessing it
> > outside dns.c.
>
> Let me tell you this again. Please ponder it seriously!
>
> Take a break. Use your brain to actually comprehend the meaning.
>
> Each patch should only do one substantial thing. And if **you refactor**
> something, **do it independently** with your feature addition. Don't mix
> them into a single patch.
>
> "Feature addition" **is not** a part of code refactoring. If you
> refactor something, there must not be a functional change.
>
> "Code refactoring" MUST NOT add a new feature.

Do I just need to rename the subject to "Integrate new experimental raw
DNS backend to the code base"? splitting this patch seems not a good idea
since the overall changes represent one substantial thing.

--
Ahmad Gani