From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1757871998; bh=Eyu2n43/YYqBW+7RS4y8ujgC9Zsx4YYekzJWO66+f/4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=B/eP8yX8Ia1KbuRtugsbXHEmJGQp/o3ul0EmaQnjjhMsl2eyg9cYZAofEcmCDw5Dq X3yVOZnDyYfY5YpadPw2wYcHFhVarWrH9GqV7S5rwsxhIfiicNMudLyw2MooKj1wrq TGbS2QboWXxPMbIHKo/ys4fYdxxxM9Bq6vNK4y+TLqRAGAK6KaF967X4+LdirkNFVl MpJ2J6UbNurXv5ONfD4b1k1G5W4uO5lTZQwKb/w0SkQwj2bbt14E5pP6cQw7blNKjT GQlRGyis0BIDnEr9jiVUEh7TlEloKycm2jWVcX8frSorba78dIs1fTYr/dvrQSyxca 4EN8u/FB/XYZw== Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id DD21231279D9 for ; Sun, 14 Sep 2025 17:46:38 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-56afe77bc1eso3770116e87.0 for ; Sun, 14 Sep 2025 10:46:38 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXOw2jUaDQcYGX82Qtzg3CHkQ7RbCK27lmOlNNa4v9mmHtzlkrlITVdhCOB2MbbFH46b8jk@vger.gnuweeb.org X-Gm-Message-State: AOJu0YzttyT+h1Iu0zZcwdFSWCZwhzO12izEAzhaELv2LNNwfow9+pAw ntWG4kwVaHxILf7LiH/rDaBCf+RXX4GmvFY/rNJxQWlWTgEW6w0BTQWCJYUrfxgXaHqM4c7e74Y rEmVF3ydfGP1tFyvCEF9GcWomgK93zIc= X-Google-Smtp-Source: AGHT+IGfgnCmtJ/2Gd51bDdydMuZB6mdSA3MZGzUBaYPAPh1AkV7B4nSgaqLR+A/lyFrKfxFnwBxbMhR9tEjtgGfzlc= X-Received: by 2002:a05:6512:1352:b0:573:8044:a98c with SMTP id 2adb3069b0e04-5738053edd6mr580294e87.18.1757871998341; Sun, 14 Sep 2025 10:46:38 -0700 (PDT) MIME-Version: 1.0 References: <20250914050943.184934-1-reyuki@gnuweeb.org> <20250914050943.184934-5-reyuki@gnuweeb.org> <20250914121417.GB31788-ammarfaizi2@gnuweeb.org> In-Reply-To: <20250914121417.GB31788-ammarfaizi2@gnuweeb.org> From: Ahmad Gani Date: Mon, 15 Sep 2025 00:46:01 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXwE0FtO6UaOs--8PAfNViEMOP6CiupGkR7T962ZPs33H586Fci51Fdauc8 Message-ID: Subject: Re: [PATCH gwproxy v11 4/6] gwproxy: Refactor code base to add experimental raw DNS backend To: Ammar Faizi Cc: Alviro Iskandar Setiawan , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Sun, Sep 14, 2025 at 7:14=E2=80=AFPM Ammar Faizi wrote: > On Sun, Sep 14, 2025 at 12:09:38PM +0700, Ahmad Gani wrote: > > Use fallback mechanism for raw DNS > > If *_PREFER_* is used in the restyp, the raw DNS backend will attempt t= o > > retry DNS query with different address family if it failed. > > > > Add new cmdline arguments: > > - raw-dns: enables the experimental raw DNS feature > > - dns-server: sets the default DNS server > > - session-map-cap: sets the default capacity for the session_map and st= ack.arr arrays > > > > The struct gwp_dns_ctx is now exported due to the need for accessing it > > outside dns.c. > > Let me tell you this again. Please ponder it seriously! > > Take a break. Use your brain to actually comprehend the meaning. > > Each patch should only do one substantial thing. And if **you refactor** > something, **do it independently** with your feature addition. Don't mix > them into a single patch. > > "Feature addition" **is not** a part of code refactoring. If you > refactor something, there must not be a functional change. > > "Code refactoring" MUST NOT add a new feature. Do I just need to rename the subject to "Integrate new experimental raw DNS backend to the code base"? splitting this patch seems not a good idea since the overall changes represent one substantial thing. -- Ahmad Gani