Re: [PATCH gwproxy v4 6/6] dnslookup: Make gw_ares_getaddrinfo asynchronous

[Ahmad Gani <reyuki@gnuweeb.org>]

On Wed, Aug 6, 2025 at 1:22 PM Alviro Iskandar Setiawan wrote:
> On Wed, Aug 6, 2025 at 10:57 AM Ahmad Gani wrote:
> > @@ -122,7 +122,8 @@ int serialize_answ(uint16_t txid, uint8_t *in, size_t in_len, gwdns_answ_data *o
> >         if (!out->rr_answ)
> >                 return -ENOMEM;
> >
> > -       for (size_t i = 0; i < hdr->ancount; i++) {
> > +       size_t i;
> > +       for (i = 0; i < hdr->ancount; i++) {
>
> This kind of change should be squashed.

Alright, I will squash it.

> And var declaration should be placed on the top.

I was actually thinking of moving it to the top as well, but when you
previously [1] mentioned moving the declaration, I assumed you meant it
literally—just relocating it to the top of the loop.

[1]:
- https://lore.gnuweeb.org/gwml/CAOG64qMMV1F5OnD6wXj+xgmqpn59VagC3gBos5ESO7xRs5Qv7g@mail.gmail.com/

--
Ahmad Gani