From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1754469788; bh=M1NB30xSlaeplarKIr19CTeEtz6LtLGvcSFqTyyBfow=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=u/sUaS4P1X2owEtqHtxCtkt8uZDe/6+45NA4CyeW32YUZ0lh1XGY8UaCLD+TkXwAV b3qAEG3ntQFVrvMmPDq2ZOLirKhr883v5wNnD0VxgaocVzjVVLrT/n8B4QWeFZBpCs ivEJjIS+AB+A5niiZK7RZ4cnLV9g0R5l8XFwQBe0a1hwSRLUPdOLICD1RncpVYqil3 UqUi5gSmP7yWVkzp7YNo6LydgLYKJb/lYL6O/8w+8PfwlNqwlhp+oWvboVxS1Ua2dR /1BXP1ClN0IC7Men3lbK06iw6pwBze4HYWUKR/7ppy0y/vifgc0M+283SLxmUcD/Gg wvAy5fwSlALlg== Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id DA0583127B0B for ; Wed, 6 Aug 2025 08:43:08 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-3323b99094fso38847951fa.0 for ; Wed, 06 Aug 2025 01:43:08 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUwq4CnqNlNOMLfkb8j/jgqI6KDQz9upGQDwZRte63RVbny82jm/oj/gaLexTG6wnpv55tn@vger.gnuweeb.org X-Gm-Message-State: AOJu0Yxdwh0TOD/f+LRj5is6WQz3no7HfN8zNRU0cRIrnhvA4q/izu7E +LSamDaTWYP+oOJ0UFrjTwCuDWQ3YjOp6iESoN3sZsOxQX6AkecMpwsFFXp0b8YNOrZsIfaTg27 9H6aEnHD6m+GC2gpCd426pK+UpONJums= X-Google-Smtp-Source: AGHT+IEwVh4pJAROUYRMhsgTyYTmy4XakkvcG2A4HHnndZe6z/DjWWeulGqSDvNTKXUifvogqQD/bXiUByaqLQDqf04= X-Received: by 2002:a05:651c:4008:b0:327:e0ac:bd8c with SMTP id 38308e7fff4ca-33381434944mr3964701fa.37.1754469788251; Wed, 06 Aug 2025 01:43:08 -0700 (PDT) MIME-Version: 1.0 References: <20250806035727.216702-1-reyuki@gnuweeb.org> <20250806035727.216702-7-reyuki@gnuweeb.org> In-Reply-To: From: Ahmad Gani Date: Wed, 6 Aug 2025 15:42:31 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXyj1LPieOlm2O0EBz9D19-NQx478aLgMRdS8iOfUsSV0zqzOlQPSTomeqI Message-ID: Subject: Re: [PATCH gwproxy v4 6/6] dnslookup: Make gw_ares_getaddrinfo asynchronous To: Alviro Iskandar Setiawan Cc: Ammar Faizi , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Wed, Aug 6, 2025 at 1:22=E2=80=AFPM Alviro Iskandar Setiawan wrote: > On Wed, Aug 6, 2025 at 10:57=E2=80=AFAM Ahmad Gani wrote: > > @@ -122,7 +122,8 @@ int serialize_answ(uint16_t txid, uint8_t *in, size= _t in_len, gwdns_answ_data *o > > if (!out->rr_answ) > > return -ENOMEM; > > > > - for (size_t i =3D 0; i < hdr->ancount; i++) { > > + size_t i; > > + for (i =3D 0; i < hdr->ancount; i++) { > > This kind of change should be squashed. Alright, I will squash it. > And var declaration should be placed on the top. I was actually thinking of moving it to the top as well, but when you previously [1] mentioned moving the declaration, I assumed you meant it literally=E2=80=94just relocating it to the top of the loop. [1]: - https://lore.gnuweeb.org/gwml/CAOG64qMMV1F5OnD6wXj+xgmqpn59VagC3gBos5ESO7= xRs5Qv7g@mail.gmail.com/ -- Ahmad Gani