From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1754469676; bh=2WqyayTfjSMvJxhDW9ubn2FtkvJfpxUg9J8OKFsR+Fo=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=NxPZB6AWtxv4VYeZ87PCKRmG18M+W65OXQ4+woOtt4wto+6DvbEzvFUzp7ruvsx+Y mDd28XmEQUqScOeS+r3H+GPNljP5vyZ1pw1WAuzHeR/7Ocmn9jzErd4eHnu3xwuUcQ 3GvfgUIV6aTcq6bNNBzYY0hxHb/UGNQ0L4ONY+7MkiEr3awWAlnmKOeXHAslD9nCSB tz15Ey3lzAFdIxWfTYqfCgWC/NeIm2IBirvKRMSQEsAiUV5phkvA/XEalp+an++RQK gubtLxbCxFmd1KBocXZkqV9rYsg9lVeb1ky1L0kzOWKdYTb6iKHH9hVouAF8bEWAvr 1QFMcAKiMXDHA== Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 810AC3127B0B for ; Wed, 6 Aug 2025 08:41:16 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-55b9375d703so5831955e87.3 for ; Wed, 06 Aug 2025 01:41:16 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVO/AntTgM0XyJ+t2QE5nlresG8r0+R3m1gRTSIXzQn9bFAz16kj/+BxDYt9bp4oAqQAD0g@vger.gnuweeb.org X-Gm-Message-State: AOJu0YwQHH5cuU+LYU+QpbCtg+KJbc/cBFuJTeH58Sz9corwNkcPTQCV ZnNqAF+N6d+aiAr8ljt4ilBVTpR6DAYLYmEJAfsQERFht2BbMed65NzW3MJE1KmTEYuC06Eg9aV PXVbmJynoTXE/qrf7A5fgR1W9vAdiQ34= X-Google-Smtp-Source: AGHT+IF3eyNe3s3x7/QcM3jYb5RvKiia3VoPIu04lUp8P9MQ958o0AQkf1gK4q3Qd34VgiGR57Y60CROUDn+Mm3ycX0= X-Received: by 2002:a05:6512:3f18:b0:553:a740:18aa with SMTP id 2adb3069b0e04-55caf38b477mr649843e87.22.1754469675712; Wed, 06 Aug 2025 01:41:15 -0700 (PDT) MIME-Version: 1.0 References: <20250806035727.216702-1-reyuki@gnuweeb.org> <20250806035727.216702-5-reyuki@gnuweeb.org> In-Reply-To: From: Ahmad Gani Date: Wed, 6 Aug 2025 15:40:39 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXzIXqepQU4mlbUlqlihMUe2n2WqfBwcfmrYXaKf6Ec1fStOI5Slzo_C-nE Message-ID: Subject: Re: [PATCH gwproxy v4 4/6] dnslookup: Initial work for implementation of C-ares-like getaddrinfo function To: Alviro Iskandar Setiawan Cc: Ammar Faizi , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Wed, Aug 6, 2025 at 1:41=E2=80=AFPM Alviro Iskandar Setiawan wrote: > On Wed, Aug 6, 2025 at 10:57=E2=80=AFAM Ahmad Gani wrote: > > +int gw_ares_init(gw_ares_channel_t **channel, struct gw_ares_options *= opts) > > +{ > > + gw_ares_channel_t *c; > > + int ret; > > + > > + if (!opts->nr_server) > > + return -EINVAL; > > + > > + c =3D malloc(sizeof(*c)); > > + if (!c) > > + return -ENOMEM; > > + > > + *channel =3D c; > > + c->nr_server =3D opts->nr_server; > > + c->servers =3D malloc(c->nr_server * sizeof(*c->servers)); > > + if (!c->servers) { > > + free(c); > > + return -ENOMEM; > > + } > > + /* > > + * TODO(reyuki): validate flags and > > + * for now use it to control recursion desired (RD) bit? > > + */ > > + c->flags =3D opts->flags; > > + for (int i =3D 0; i < c->nr_server; i++) { > > + ret =3D convert_str_to_ssaddr(opts->servers[i], &c->ser= vers[i], DEFAULT_DOMAIN_PORT); > > + if (ret) { > > + free(c->servers); > > + free(c); > > + return ret; > > + } > > + } > > + > > + return 0; > > +} > > Again, I don't see any point in filling `*channel` with a dangling > pointer on error. > > This part "*channel =3D c", can't you do that only when successful? > > Please address the previous review properly. Don't ignore comments. Eh, sorry=E2=80=94I overlooked that. I didn't recheck it because I assumed = it was acceptable, since there were no comments on patchset v2 where the change was first made. By "avoiding a dangling pointer", I thought the request meant not to assign to the channel if memory allocation for c failed. Anyway, don't worry, I will update it in the next patchset. -- Ahmad Gani