Re: [PATCH gwproxy v0] epoll: Improve log readability and efficiency

[Ahmad Gani <reyuki@gnuweeb.org>]

On Sun, Aug 17, 2025 at 11:57 AM Ammar Faizi wrote:
> On Sun, Aug 17, 2025 at 11:49:13AM +0700, Ahmad Gani wrote:
> > By the way, I wonder why GWP_CONN_FLAG_NO_CLOSE_FD exists? Can you explain
> > the use cases for such a thing to exist?
> >
> > Wouldn't it cause a file descriptor leak too?
>
> I should have explained it better.
>
> GWP_CONN_FLAG_NO_CLOSE_FD is only used from the io_uring case.
>
> __sys_close() is a heavy syscall and better be done asynchronously via
> prep_close() in io_uring context.
>
> GWP_CONN_FLAG_NO_CLOSE_FD allows log_conn_pair_close() to log the fd
> numbers without the obligation to call __sys_close() in free_conn().
>
> Previously, it was confusing to debug when the fd is set to -1 by
> the gwp_free_conn_pair()'s caller.
>
> GWP_CONN_FLAG_NO_CLOSE_FD simply means the fds are no longer owned by gcp.

I see; now it makes sense. Thanks for the explanation!

--
Ahmad Gani