From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1754388985; bh=NdX6Q6Kh77zvd7e2liAS9Xx2GZvkGHTNyp7LlGQILSU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=lP/JELPy2vxY6gZREgktQozrlyLE7Yvl4bWmwCnBtsZrsQ2SgiOkhvLPJl0W9lzx5 19Uw+UuXkgsNHzCh043kPdb55x6WBA143/DNm/6ayTssccjR7uEzbv6Ica4CJXOvVc aRzm33fsP3vX9iSbtokHaWrpvS5IKSZgVfofRcMkg/0SDfgmUXY5fwPMpBPx8meCwL gJhxx6edykpxrMgGqJhdv1HyTP3Pv6cpK4Wa+vyv8a7OXs785UsYegEzrv5cYtftVd FoUmQNhX2KlCAbRPbFZO99/sf+3aiR93h81Ju06RQ2rQY/VYiNXrFJNV/uT+AOiOSt XpFaXd/RCZt4w== Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id B2F26312804C for ; Tue, 5 Aug 2025 10:16:25 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-55b7e35a452so6612027e87.2 for ; Tue, 05 Aug 2025 03:16:25 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUXNmDIp93l3x4oZl6ytupY9lRxE7Kpg/h+y5FQByYtgfTy003dIZCXzTRmYOYjQLvM43iF@vger.gnuweeb.org X-Gm-Message-State: AOJu0YxZ5erYSPAS3Ayn7PW9wyhPMuvgeBSn9iWMbQsMTvwCGNWJtLjI 9XDeqIsLqrN2flAUaTvu1mvja2VzEqtenkouFvakUgY5mZMEj2mu7H37qHdrPWfyZezKxTaeFrn UnEYrTuh3Vqzf1SmTih4TR0uMDXkFlPw= X-Google-Smtp-Source: AGHT+IHqsqmv5CjqWwVPLnRuvjcy/gunzK33MyN1R2TnxvTIXXXuQOx0N2NMF35IR4ppMpwGW8BtF38aA2xduT9ifW0= X-Received: by 2002:a05:6512:3988:b0:55a:43b6:f200 with SMTP id 2adb3069b0e04-55b97b89080mr3549607e87.55.1754388985125; Tue, 05 Aug 2025 03:16:25 -0700 (PDT) MIME-Version: 1.0 References: <20250805064933.109080-1-reyuki@gnuweeb.org> <20250805064933.109080-3-reyuki@gnuweeb.org> In-Reply-To: From: reyuki Date: Tue, 5 Aug 2025 17:15:46 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXxkwMF_ViLHsCaqUo1gJnISV_F3xxNwN-XTTCajjlseS3-cNF_n9Bb0078 Message-ID: Subject: Re: [PATCH gwproxy v3 2/9] dnslookup: Add a new parameter, default_port. To: Ammar Faizi Cc: Alviro Iskandar Setiawan , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Tue, Aug 5, 2025 at 4:26=E2=80=AFPM Ammar Faizi wrote: > On Tue, Aug 05, 2025 at 01:49:22PM +0700, Ahmad Gani wrote: > > default_port as parameter in convert_str_to_ssaddr function is needed > > when separator ':' does not exists in the provided address string. > > No. > > This patch doesn't add a new parameter. You're just renaming prt to > default_port. It should be squashed into a real patch that adds a new > parameter. In the previous message, you mentioned that the new parameter should be separated from patch 1/9. Is it okay if I pick the commit for patch 1/9 during git rebase, edit it to remove prt, and preserve patch 2/9 as it is? -- Ahmad Gani