From: Ahmad Gani <reyuki@gnuweeb.org>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
"GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v7 0/2] Initial work on integration of DNS parser lib in gwproxy
Date: Fri, 29 Aug 2025 14:39:54 +0700 [thread overview]
Message-ID: <CAADvAgq7GbxJymsWYQWBEfXy_kX5f8pmZfb6iRTucw9vZsx6Kg@mail.gmail.com> (raw)
In-Reply-To: <CAFBCWQKQDoHuYmbY3+GSa8hUc0HhTrMxiz2KqM8VBaD7nHD+ew@mail.gmail.com>
On Fri, Aug 29, 2025 at 2:31 PM Ammar Faizi wrote:
> FWIW, I tried to run the checkpatch.pl script on your patch #2. Here
> is the result:
>
> https://gist.github.com/ammarfaizi2/589dfc9cdef9963cfa854273d8702ca7
>
> The most bothersome part is the error, obviously. That whitespace. If
> you can be clean, that would be great.
Cool. it can detect something that compiler didn't catch:
```
WARNING: break is not useful after a goto
#229: FILE: src/gwproxy/dns.c:282:
+ goto exit_free_ai;
+ break;
```
next prev parent reply other threads:[~2025-08-29 7:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 3:36 [PATCH gwproxy v7 0/2] Initial work on integration of DNS parser lib in gwproxy Ahmad Gani
2025-08-29 3:36 ` [PATCH gwproxy v7 1/2] dnsparser: Add dns parser code Ahmad Gani
2025-08-29 4:39 ` Ammar Faizi
2025-08-29 3:36 ` [PATCH gwproxy v7 2/2] gwproxy: refactor code base to add experimental raw DNS backend Ahmad Gani
2025-08-29 4:36 ` Ammar Faizi
2025-08-29 7:35 ` Ahmad Gani
2025-08-29 7:39 ` Ammar Faizi
2025-08-29 4:36 ` [PATCH gwproxy v7 0/2] Initial work on integration of DNS parser lib in gwproxy Ammar Faizi
2025-08-29 6:57 ` Ahmad Gani
2025-08-29 7:22 ` Ammar Faizi
2025-08-29 7:30 ` Ammar Faizi
2025-08-29 7:39 ` Ahmad Gani [this message]
2025-08-29 7:45 ` Ammar Faizi
2025-08-29 7:36 ` Ammar Faizi
2025-08-29 7:51 ` Ahmad Gani
2025-08-29 8:00 ` Ammar Faizi
2025-08-29 8:06 ` Ahmad Gani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADvAgq7GbxJymsWYQWBEfXy_kX5f8pmZfb6iRTucw9vZsx6Kg@mail.gmail.com \
--to=reyuki@gnuweeb.org \
--cc=alviro.iskandar@gnuweeb.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox