From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <reyuki@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS,
	URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no
	version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1756453232;
	bh=8jp3y87K/Kh733F5JArTk62E++uLvWIpAH5rweAPljg=;
	h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
	 To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From:
	 Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date:
	 Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type:
	 Content-Transfer-Encoding;
	b=q3Ac0Knh1K56ACLMKhVMZfc4RnvV7bKozzIkv8FrO95RORRRtUHHkXBDpqGFyUFM7
	 MRBHs4XeyEk9WT07iic3Ogbc2TBZGY1uFV5rr73T3Lr+baT2kafpx5qcyn/9tX0O0n
	 JMM0rdNcVqnU00L1odCQSkK5qJIeNQfmt70qgTUnSQVmQHbDw9KO1lSJuRThRT7V5r
	 kwrIt/zFLOY0f+bSdH1z8SMyi17sNiLdbHJxuMNlgCuCpqjDGhVHzCdhx2oBtK7Ith
	 2ljcMX4k9vBaUMJ9Q1fD+FmZ06AyaXYyrI5Qy9Nmdq4OnXHqNDbZ0WV95hqDDAuVav
	 Am/RZoDfa58cg==
Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 966F03127F77
	for <gwml@vger.gnuweeb.org>; Fri, 29 Aug 2025 07:40:32 +0000 (UTC)
Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-336b82c03ecso2637301fa.0
        for <gwml@vger.gnuweeb.org>; Fri, 29 Aug 2025 00:40:32 -0700 (PDT)
X-Forwarded-Encrypted: i=1; AJvYcCXajLv7WiAKRJbxOUHPwPm+QljIDzybvFHYQLwKG05bcZ5lmF0CQAgUOPAG0+Sj8RCiZZra@vger.gnuweeb.org
X-Gm-Message-State: AOJu0Yzcs3jjNF9w8uYfWI6nBHmc8Km92CoRnNJ3OOKMT+Sy3af3lGoT
	k2oZKnMaEsDxnlCVfKOg3V3aJHNTbrp/UP7gdL2aOpyH6qVu6MO1J5A66w286RY+L0vc4lzwSwU
	SIs+Jud7Y1TesoYWY87bEKMgBDmHHBTk=
X-Google-Smtp-Source: AGHT+IFtDJ8raFfRbIxCPlE1yEgraN4aijMHO7SGBB+JMGUhbxnyP21U1gtqHCo32XTmVXqt89AFRb6zdKcF0x1FsA8=
X-Received: by 2002:a2e:bc15:0:b0:336:7af2:6f2b with SMTP id
 38308e7fff4ca-3367af2806cmr45276531fa.9.1756453231975; Fri, 29 Aug 2025
 00:40:31 -0700 (PDT)
MIME-Version: 1.0
References: <20250829033628.573589-1-reyuki@gnuweeb.org> <20250829043632.GA652664-ammarfaizi2@gnuweeb.org>
 <CAADvAgoM35B4cY6YOm=yMKPnpayG5mouTOLqWCMx66h9tzwk5w@mail.gmail.com>
 <CAFBCWQ+6K7MA8SMRd6Di7qAXzSr-5pv=WDMTrWHpuV600JLaAQ@mail.gmail.com> <CAFBCWQKQDoHuYmbY3+GSa8hUc0HhTrMxiz2KqM8VBaD7nHD+ew@mail.gmail.com>
In-Reply-To: <CAFBCWQKQDoHuYmbY3+GSa8hUc0HhTrMxiz2KqM8VBaD7nHD+ew@mail.gmail.com>
From: Ahmad Gani <reyuki@gnuweeb.org>
Date: Fri, 29 Aug 2025 14:39:54 +0700
X-Gmail-Original-Message-ID: <CAADvAgq7GbxJymsWYQWBEfXy_kX5f8pmZfb6iRTucw9vZsx6Kg@mail.gmail.com>
X-Gm-Features: Ac12FXwrVSbgMBh2jwCtcZSFDi5WKyyZTzkU0niQl6DAgOXbeh9g2hASqXUdmHk
Message-ID: <CAADvAgq7GbxJymsWYQWBEfXy_kX5f8pmZfb6iRTucw9vZsx6Kg@mail.gmail.com>
Subject: Re: [PATCH gwproxy v7 0/2] Initial work on integration of DNS parser
 lib in gwproxy
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>, 
	"GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <gwml.vger.gnuweeb.org>

On Fri, Aug 29, 2025 at 2:31=E2=80=AFPM Ammar Faizi wrote:
> FWIW, I tried to run the checkpatch.pl script on your patch #2. Here
> is the result:
>
>   https://gist.github.com/ammarfaizi2/589dfc9cdef9963cfa854273d8702ca7
>
> The most bothersome part is the error, obviously. That whitespace. If
> you can be clean, that would be great.

Cool. it can detect something that compiler didn't catch:
```
WARNING: break is not useful after a goto
#229: FILE: src/gwproxy/dns.c:282:
+ goto exit_free_ai;
+ break;
```