From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1757135840; bh=gmXcq1BwLm4rCjxwgImVm1e6k+6DBj/pl417HYthnTQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=g1wK5TV+07MfWpXIz8gl+JC+AvB26C2RtjegkF/ksssYz3RRKyFZtg1z7bZFRCTkF c/4gtnde7+AjFMIFjrl7lCfxek7/wstXUM4ppNHL6Xa9gQaDSMn8BsTMDrx37yf+CQ 48lr3L/jzJFph4JmAYH1dembxNqMRWG+liIyTy2GAuuPB7LIS66famRoZb2SxnRRKi 9swFleenroOO5aHbVtRPf8WWV4wryu6m6ubzIus85a2uoFkdxk+IW2abzg+nSRSNGe Z7O8wbOFa8WrsGhDgNgXtBTNkCrjJ404i6ak7jsKPv+m0wuDijiqLfQbkD43FN6VoZ aPCAvuEHMoFkQ== Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id D3E733127A95 for ; Sat, 6 Sep 2025 05:17:20 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-336ce4a894cso20998101fa.1 for ; Fri, 05 Sep 2025 22:17:20 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUUxVm2YpEDuj6KmxebnksR1R49vSItGrY9A3NKc/wPUrDuO4HSy21onAy8I04QHX+DA5PI@vger.gnuweeb.org X-Gm-Message-State: AOJu0Yxy5zWc86kMNu38NztwgpuhOsAkTwKPlfd0eeFdMO2+7G5UAucf Dp3zB79+3g1ayyZuDeHPOONhdV2ZkoD/IdcY3RENGhdDEj45jgSSEW1ow+hR/6pquIXtUIfouMI lq6DuIjUDXJ3Xuy7wPYzMcdtrTKf13UI= X-Google-Smtp-Source: AGHT+IGhzjOsqoJ9R+mozXK9m4Jga3WIhI+BHELYwCsHBIY4QP/2mExVLVEUKcqpCUcqFebe8RFMaKcapFvhacTOlEg= X-Received: by 2002:a2e:a008:0:b0:336:93f6:8e70 with SMTP id 38308e7fff4ca-33b56fb0c23mr1948521fa.8.1757135840204; Fri, 05 Sep 2025 22:17:20 -0700 (PDT) MIME-Version: 1.0 References: <20250829075557.598176-1-reyuki@gnuweeb.org> <20250829075557.598176-3-reyuki@gnuweeb.org> In-Reply-To: From: Ahmad Gani Date: Sat, 6 Sep 2025 12:16:43 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXysyUQLXg__CFBa0ajPwfSfHLFqIetY2aegxEEBqVNyhPnP64P1ffmnosM Message-ID: Subject: Re: [PATCH gwproxy v8 2/2] gwproxy: refactor code base to add experimental raw DNS backend To: Alviro Iskandar Setiawan Cc: Ammar Faizi , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Sat, Sep 6, 2025 at 11:32=E2=80=AFAM Ahmad Gani wrote: > On Fri, Sep 5, 2025 at 11:26=E2=80=AFPM Alviro Iskandar Setiawan wrote: > > Having #ifdef CONFIG_RAW_DNS all over the place is horrible. Please do > > something else to reduce them. CTRL + F, "def CONFIG_RAW_DNS", 24 > > matches. > > I thought it was necessary to mark that a certain block belongs to the > experimental raw DNS feature. If I reduce the use of these marks, it migh= t > introduce unnecessary code into the compiled version when this experiment= al > feature is disabled. However, I will reduce the `#ifdef CONFIG_RAW_DNS` where possible. -- Ahmad Gani