public inbox for gwml@vger.gnuweeb.org
 help / color / mirror / Atom feed
From: Ahmad Gani <reyuki@gnuweeb.org>
To: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
	"GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v4 4/6] dnslookup: Initial work for implementation of C-ares-like getaddrinfo function
Date: Wed, 6 Aug 2025 15:43:38 +0700	[thread overview]
Message-ID: <CAADvAgqPQQSamvwMxxneWDgqABOyhHqUi+TB-aRV5QLODgYwxQ@mail.gmail.com> (raw)
In-Reply-To: <CAOG64qOA+dRzV5T8C5sWeZcnAx0Ow5v=MZ+dTXZbzzu1npMFbw@mail.gmail.com>

On Wed, Aug 6, 2025 at 1:51 PM Alviro Iskandar Setiawan wrote:
> Also, the for loop needs a coding style fix. Don't declare the
> variable inside the for loop argument. Please stop repeating the same
> mistake again and again.
>
> DO NOT DO THIS:
>
>         for (int i = 0; i < N; i++) {
>                 something;
>                 something;
>         }
>
> DO THIS:
>
>         int i;
>         for (i = 0; i < N; i++) {
>                 something;
>                 something;
>         }

Hmm, I already removed the declaration inside the for loop statements, but
it seems the patches weren't synchronized with my local file. I apologize
for overlooking this, I will try to recheck each patch to avoid the
same mistakes.

--
Ahmad Gani

  reply	other threads:[~2025-08-06  8:44 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-06  3:57 [PATCH gwproxy v4 0/6] Initial work for DNS lookup implementation Ahmad Gani
2025-08-06  3:57 ` [PATCH gwproxy v4 1/6] dnslookup: Split common functionality and struct into net.h and net.c Ahmad Gani
2025-08-06  6:18   ` Alviro Iskandar Setiawan
2025-08-06  3:57 ` [PATCH gwproxy v4 2/6] dnslookup: Add a new parameter default_port Ahmad Gani
2025-08-06  6:20   ` Alviro Iskandar Setiawan
2025-08-06  3:57 ` [PATCH gwproxy v4 3/6] dnslookup: Allow only port string number Ahmad Gani
2025-08-06  3:57 ` [PATCH gwproxy v4 4/6] dnslookup: Initial work for implementation of C-ares-like getaddrinfo function Ahmad Gani
2025-08-06  6:40   ` Alviro Iskandar Setiawan
2025-08-06  6:51     ` Alviro Iskandar Setiawan
2025-08-06  8:43       ` Ahmad Gani [this message]
2025-08-06  8:40     ` Ahmad Gani
2025-08-06 11:09   ` Alviro Iskandar Setiawan
2025-08-06 11:20     ` Alviro Iskandar Setiawan
2025-08-06 11:39       ` Ammar Faizi
2025-08-06 12:30         ` Ahmad Gani
2025-08-06 20:54           ` Ammar Faizi
2025-08-06 12:30       ` Ahmad Gani
2025-08-06 21:33         ` Ammar Faizi
2025-08-14  4:54           ` Ahmad Gani
2025-08-06  3:57 ` [PATCH gwproxy v4 5/6] dnsparser: Transaction id creation is delegated to caller Ahmad Gani
2025-08-06  6:28   ` Alviro Iskandar Setiawan
2025-08-06 10:20     ` Ahmad Gani
2025-08-06 10:51       ` Alviro Iskandar Setiawan
2025-08-06 12:29         ` Ahmad Gani
2025-08-06  3:57 ` [PATCH gwproxy v4 6/6] dnslookup: Make gw_ares_getaddrinfo asynchronous Ahmad Gani
2025-08-06  6:22   ` Alviro Iskandar Setiawan
2025-08-06  8:42     ` Ahmad Gani
2025-08-06  7:03 ` [PATCH gwproxy v4 0/6] Initial work for DNS lookup implementation Ammar Faizi
2025-08-06  7:08 ` Ammar Faizi
2025-08-06  8:37   ` Ahmad Gani
2025-08-06  8:58     ` Ammar Faizi
2025-08-06  9:47       ` Ammar Faizi
2025-08-06 20:50         ` Ammar Faizi
2025-08-06 22:14     ` Ammar Faizi
2025-08-06  7:08 ` (subset) " Ammar Faizi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAADvAgqPQQSamvwMxxneWDgqABOyhHqUi+TB-aRV5QLODgYwxQ@mail.gmail.com \
    --to=reyuki@gnuweeb.org \
    --cc=alviro.iskandar@gnuweeb.org \
    --cc=ammarfaizi2@gnuweeb.org \
    --cc=gwml@vger.gnuweeb.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox