From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1754469855; bh=bjvb78B9B9kzcAz15iAsDF0E3oqIF1uMCydQoJ0x87c=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=tBEdOEixRzg3/7h0flA4KrLSh9tZmzLeH4bE3Qqx+P1xDSRCVt1JOzRjrXB/BUWoQ AkMNuqIE5nTo1fJpk76+3r7sFmrm4lf+IDn7yDvEJ3m7/4JAgKCCtuHcMRXdPCuZYM q996P7I+bhREDdi0gYf58gx3m6+47fZWDLKfaSLqFNbstiWIpSCymHV02Ex0L6u/Cs 8oLg4DNmHJiNIBIni57aKCaYpZxkX0yKnrgxJ+ABqleBjbDlLI/vBiB+86hEtepMJy bqpQm8A0FVdMbWMGedWjqlO9ipO/IGfmlE4l4ew2CyPxn1HHJbHvW4rFIafiotDCxN GpHGSIHBfgguw== Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 74D503127B0D for ; Wed, 6 Aug 2025 08:44:15 +0000 (UTC) Received: by mail-lj1-f174.google.com with SMTP id 38308e7fff4ca-32ce1b2188dso63108901fa.3 for ; Wed, 06 Aug 2025 01:44:15 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUdX3N+UrXE8hPXrBuHRX0idGkGwsQIh8JvlPyOcy70OR8tbcPQiZ9FTyepi2iObuYy6mR2@vger.gnuweeb.org X-Gm-Message-State: AOJu0YxfhbVnAV4eaIXECqho+tk6YZusr5LhcCDnUVUQ/FqV6kgmmnjc l9x7e3YZ6C8yECVwtYoJW3gwGWbPfSAyJpwS/bCaraN5pfS4U5lzzHlVfrfYXWs0lagl2jK/Kj1 UEA3txP/Kf0LDDSLcIcLA28U28Yx6kUo= X-Google-Smtp-Source: AGHT+IFWyFXjV/nJOz2yVT2FsPg25XOeqUHmvMe4itESMu+ybWJKtE8E0h/nnvzYGiPdCssptSooADbkxxlUizAdX9c= X-Received: by 2002:a05:651c:20cc:10b0:333:7e5b:15c7 with SMTP id 38308e7fff4ca-3338126b3ccmr3005051fa.13.1754469854864; Wed, 06 Aug 2025 01:44:14 -0700 (PDT) MIME-Version: 1.0 References: <20250806035727.216702-1-reyuki@gnuweeb.org> <20250806035727.216702-5-reyuki@gnuweeb.org> In-Reply-To: From: Ahmad Gani Date: Wed, 6 Aug 2025 15:43:38 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXwes5XKs_oBsgo15IKXlrz3vYYkCJaqQJx2XkrhloOCzDU5vq_6pO3Oqjg Message-ID: Subject: Re: [PATCH gwproxy v4 4/6] dnslookup: Initial work for implementation of C-ares-like getaddrinfo function To: Alviro Iskandar Setiawan Cc: Ammar Faizi , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Wed, Aug 6, 2025 at 1:51=E2=80=AFPM Alviro Iskandar Setiawan wrote: > Also, the for loop needs a coding style fix. Don't declare the > variable inside the for loop argument. Please stop repeating the same > mistake again and again. > > DO NOT DO THIS: > > for (int i =3D 0; i < N; i++) { > something; > something; > } > > DO THIS: > > int i; > for (i =3D 0; i < N; i++) { > something; > something; > } Hmm, I already removed the declaration inside the for loop statements, but it seems the patches weren't synchronized with my local file. I apologize for overlooking this, I will try to recheck each patch to avoid the same mistakes. -- Ahmad Gani