Re: [PATCH gwproxy v5 2/2] dnsparser: Add dns parser code

[Ahmad Gani <reyuki@gnuweeb.org>]

On Sat, Aug 23, 2025 at 8:52 AM Ammar Faizi wrote:
> I will ask for your feature to be experimental because your DNS feature
> is not super simple. It may have undiscovered hidden bugs even if we
> have extensively tested it. The same thing with the io_uring support.
>
> And note that, getaddrinfo() is not as simple as resolving DNS queries
> via UDP port 53. It does more than that. For example, it reads
> /etc/hosts, /etc/resolv.conf, /etc/gai.conf and many more files.
>
> If we missed very important details and the old resolver is already
> removed, it will be a pain in the ass to 'git revert' all your work.
>
> So please, keep the old feature intact for the time being. Develop a
> new DNS resolver without bothering the old DNS feature. It's not that
> simple to replace this monster.
>
> And the good thing is that, making it an experimental feature allows
> specific environments to use the feature in a stable release, but
> keeping the old stable feature usable for those who are not willing to
> get involved in testing and reporting bugs.

Alright, that sounds reasonable. I’ll revert any changes that remove the
old DNS resolver part.

One question though: should the option be compile-time
with a -dev binary, or runtime via command-line parameters?

--
Ahmad Gani