Re: [PATCH gwproxy v10 2/2] gwproxy: refactor code base to add experimental raw DNS backend

[Ahmad Gani <reyuki@gnuweeb.org>]

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

On Sat, Sep 13, 2025 at 12:36 AM Ammar Faizi wrote:
> On Thu, Sep 11, 2025 at 05:11:11PM +0700, Alviro Iskandar Setiawan wrote:
> > Anyway, this patch is doing too many things. It's not something you
> > should do in a single commit. Please split it into smaller, more
> > manageable pieces.
>
> Indeed. This patch does too many things at once.
>
> @Ahmad Gani, each patch should only do one substantial thing. Your patch
> definitely needs to be split into smaller patches. If you want to
> refactor something, do it indenpendently with your feature addiation.
>
> For example:
>   Patch 1: Export 'struct gwp_dns_ctx'.
>   Patch 2: Add DNS parser code.
>   Patch 3: Add stack code.
>   Patch 4: Refactor something blablabla...
>   Patch 5: Move it to that in order to blablabla...
>   Patch 6: Integrate raw DNS feature to epoll.
>   Patch 7: Integrate raw DNS feature to io_uring.
>   Patch 8: Add --session-map-cap option.
>   and so on...
>
> This series is also a good example of splitting patches:
> https://lore.kernel.org/io-uring/20240921080307.185186-1-axboe@kernel.dk/
>
> P.S. Don't follow the example as is, adjust it with your own situation.
> I don't want you arguing: "You gave me that example, so I did exactly
> what you told me, even if it's not suitable for the situation in
> question.".

Understood, I'll revise and split the patch.

--
Ahmad Gani

[-- Attachment #2: Type: text/html, Size: 1753 bytes --]