From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE, URIBL_DBL_BLOCKED_OPENDNS,URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1757824530; bh=MaUtIzrThobA9qB41/xSvtXOUbkMXuuqDY3Jv/X+V2o=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Message-ID:Date:From:Reply-To:Subject:To:Cc: In-Reply-To:References:Resent-Date:Resent-From:Resent-To:Resent-Cc: User-Agent:Content-Type:Content-Transfer-Encoding; b=Bsfqzww4lf/c9PknmHtka7OmJZRG8JufRgz594ezXAfMUMS2tTySmaXLaMamlpXZm YSmAEOPgOhMzhurnaPBRK5LRnCUCzVzfYNArcBvSfdSmJp2uXu3KkCCL5H/BGCiK+J K16dajYmjkXFBGWmlyz7ucoXj1lEKuYrp+30fN4RfNHVOs4Nc68/K/5ObCZeyFsuoc e/IFQ26Pyho1XostfMgTONOEqEIcyjwyll6yhGmEgN2l8XYzFdO2PNa2IMWPEQIB/O nUwtjoWdbOXjOEgUgh5qRCaQnp+jy36p7G71xne5t0tCXaoeGdo5ItI9Ax558UF4wM vcqocW/iGh50w== Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 7D9EB31279AF for ; Sun, 14 Sep 2025 04:35:30 +0000 (UTC) Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-336c2194a65so24252331fa.2 for ; Sat, 13 Sep 2025 21:35:30 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXU4+ONDVsnPBC3SngBiTfUvFNwbOPyzm61VvFccjY33ML/IbTDJ3JBc09FN0m9yhPveddm@vger.gnuweeb.org X-Gm-Message-State: AOJu0YzvTHVGxzovyUC5GRBLpr31V7UjZwBGzDk3qCHicttSRRMG164c 2+Yf2Wiy3FPNLTR3UVlsT3n3CwobDoByDcf/RIwjNcUmHU9IjdDY5aSZrTKP2IXPr236dJdKekd slsAU7HvJmW2zMh8yC4bWYsLHrWljnGY= X-Google-Smtp-Source: AGHT+IFFJY8IfhtYiT9a+vzjBXKByEYlXOO4TPIDTK2nJibFHpqUowQyYlWxL9niyASvGxV9ZZAnob5VpBf9kAb2d+g= X-Received: by 2002:a2e:be11:0:b0:352:b6c0:d378 with SMTP id 38308e7fff4ca-352b6df6028mr17251251fa.32.1757824529876; Sat, 13 Sep 2025 21:35:29 -0700 (PDT) MIME-Version: 1.0 References: <20250910104326.580778-1-reyuki@gnuweeb.org> <20250910104326.580778-3-reyuki@gnuweeb.org> <20250912173607.GB3885112-ammarfaizi2@gnuweeb.org> In-Reply-To: <20250912173607.GB3885112-ammarfaizi2@gnuweeb.org> From: Ahmad Gani Date: Sun, 14 Sep 2025 11:34:53 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXx4pyVWJ_dUzk_m3uSbw2pA-Sh4eCcCAX-zTM04diTHJOODLAi0vE_oNKg Message-ID: Subject: Re: [PATCH gwproxy v10 2/2] gwproxy: refactor code base to add experimental raw DNS backend To: Ammar Faizi Cc: Alviro Iskandar Setiawan , "GNU/Weeb Mailing List" Content-Type: multipart/alternative; boundary="000000000000ae4c57063ebb6ae9" List-Id: --000000000000ae4c57063ebb6ae9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Sep 13, 2025 at 12:36=E2=80=AFAM Ammar Faizi wrote: > On Thu, Sep 11, 2025 at 05:11:11PM +0700, Alviro Iskandar Setiawan wrote: > > Anyway, this patch is doing too many things. It's not something you > > should do in a single commit. Please split it into smaller, more > > manageable pieces. > > Indeed. This patch does too many things at once. > > @Ahmad Gani, each patch should only do one substantial thing. Your patch > definitely needs to be split into smaller patches. If you want to > refactor something, do it indenpendently with your feature addiation. > > For example: > Patch 1: Export 'struct gwp_dns_ctx'. > Patch 2: Add DNS parser code. > Patch 3: Add stack code. > Patch 4: Refactor something blablabla... > Patch 5: Move it to that in order to blablabla... > Patch 6: Integrate raw DNS feature to epoll. > Patch 7: Integrate raw DNS feature to io_uring. > Patch 8: Add --session-map-cap option. > and so on... > > This series is also a good example of splitting patches: > https://lore.kernel.org/io-uring/20240921080307.185186-1-axboe@kernel.dk/ > > P.S. Don't follow the example as is, adjust it with your own situation. > I don't want you arguing: "You gave me that example, so I did exactly > what you told me, even if it's not suitable for the situation in > question.". Understood, I'll revise and split the patch. -- Ahmad Gani --000000000000ae4c57063ebb6ae9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sat, Sep 13, 2025 at 12:36=E2=80=AFAM Ammar Faizi wrote= :
> On Thu, Sep 11, 2025 at 05:11:11PM +0700, Alviro Iskandar Setiawa= n wrote:
> > Anyway, this patch is doing too many things. It's= not something you
> > should do in a single commit. Please split = it into smaller, more
> > manageable pieces.
>
> Indee= d. This patch does too many things at once.
>
> @Ahmad Gani, ea= ch patch should only do one substantial thing. Your patch
> definitel= y needs to be split into smaller patches. If you want to
> refactor s= omething, do it indenpendently with your feature addiation.
>
>= For example:
> =C2=A0 Patch 1: Export 'struct gwp_dns_ctx'.<= br>> =C2=A0 Patch 2: Add DNS parser code.
> =C2=A0 Patch 3: Add st= ack code.
> =C2=A0 Patch 4: Refactor something blablabla...
> = =C2=A0 Patch 5: Move it to that in order to blablabla...
> =C2=A0 Pat= ch 6: Integrate raw DNS feature to epoll.
> =C2=A0 Patch 7: Integrate= raw DNS feature to io_uring.
> =C2=A0 Patch 8: Add --session-map-cap= option.
> =C2=A0 and so on...
>
> This series is also a = good example of splitting patches:
> https://lore.kernel.o= rg/io-uring/20240921080307.185186-1-axboe@kernel.dk/
>
> P.= S. Don't follow the example as is, adjust it with your own situation.> I don't want you arguing: "You gave me that example, so I d= id exactly
> what you told me, even if it's not suitable for the = situation in
> question.".

Understood, I'll revise an= d split the patch.

--
Ahmad Gani
--000000000000ae4c57063ebb6ae9--