From: reyuki <reyuki@gnuweeb.org>
To: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
"GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v2 1/3] dnslookup: split common functionality and struct into net.c
Date: Sat, 2 Aug 2025 08:08:29 +0700 [thread overview]
Message-ID: <CAADvAgqjMLHaRh4ui3jpmq_-_yfa6ND1cob+4LWuLh-ZxVBkQw@mail.gmail.com> (raw)
In-Reply-To: <CAOG64qOLbeX=YyYkHgi8R3o4rfb799z8h+c=Oo7Q7h1NagWMiA@mail.gmail.com>
On Sat, Aug 2, 2025 at 6:45 AM Alviro Iskandar Setiawan wrote:
> (( Nit: Change the var name from prt to port. The naming prt sounds weird. ))
Identifier port is already used, I will change it to default_port instead.
> That port parameter addition should be a separate patch. So this
> should be broken down into two commits:
How to split an existing commit into a separate one?
- git rebase -i base-commit
- <edit specific commit>
- make changes
- create new commit here?
--
Ahmad Gani
next prev parent reply other threads:[~2025-08-02 1:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 1:54 [PATCH gwproxy v2 0/3] Initial work for DNS lookup implementation Ahmad Gani
2025-08-01 1:54 ` [PATCH gwproxy v2 1/3] dnslookup: split common functionality and struct into net.c Ahmad Gani
2025-08-01 23:43 ` Alviro Iskandar Setiawan
2025-08-01 23:45 ` Alviro Iskandar Setiawan
2025-08-02 1:08 ` reyuki [this message]
2025-08-02 1:34 ` Alviro Iskandar Setiawan
2025-08-01 1:54 ` [PATCH gwproxy v2 2/3] dnslookup: Allow only port string number Ahmad Gani
2025-08-01 1:54 ` [PATCH gwproxy v2 3/3] dnslookup: Initial work for implementation of C-ares-like getaddrinfo function Ahmad Gani
2025-08-02 1:37 ` Alviro Iskandar Setiawan
2025-08-02 2:06 ` reyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADvAgqjMLHaRh4ui3jpmq_-_yfa6ND1cob+4LWuLh-ZxVBkQw@mail.gmail.com \
--to=reyuki@gnuweeb.org \
--cc=alviro.iskandar@gnuweeb.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox