From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1754096923; bh=kdHq+SNCYSKJDf1zLlCCA+kvCzZip/BlKh3BO9CUYQg=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=AZWsJ1VWfFohhXFyp5NUGJ7pHk4JbD4OoqXmx297W6tlg51q3xYiDDl/nRWNvW4aK XjWZqRm7InA0LTXsy+uB1mqX0lO0IKTo+UK9fnYEJ+0bqonAVdvkegSybo6V569U0j tSeyBFhF4520SzjGg61Ug/N01mqyiW58/o3CcoR9lQZPaPZCAiKN3UkmLmLMp/dMDt cg0ixOXZcJ7zUIJqSetAO9tOzfjE8dty0KVdWGkB50i4nFrVpLK951TPUYbAKrWxxf uzYuWpnF5ulu2Ao+FxcbhyLQhXPODSmJl3S5uRYOfwsyBv3wETY0RFGL0H3Ca0vHMJ Ni+HSW/9bv2eA== Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 6F1F93127B09 for ; Sat, 2 Aug 2025 01:08:43 +0000 (UTC) Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-55b85d01b79so2481980e87.3 for ; Fri, 01 Aug 2025 18:08:43 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWSclACZEYvLetSnZQE4EfH1gkwu7XIuLzKKmtRIWZyCPizcE7/sVi/Uh/y/7A6QEcl9fi7@vger.gnuweeb.org X-Gm-Message-State: AOJu0YzQ0mGS2kAGwTt9w0HOzADmu41uVP3xMDGNuuez0RzULwD2JHDh LTiUXrMct2Z8/3YOrXe34TVN3ARQg8Ufjh5JDfTamO03OWSPTiqIQiCsaYvMcJd4eQNTtwRdTJV n863fTtVFfAPTKBQ/iMdchwGiJb+D2rE= X-Google-Smtp-Source: AGHT+IENfidPkhLxjmzXiA4dQlVyCdVpUERxt4aT7F9g3PhyNJIse6MBoqaBFHuCg8tUtp0WK8FAyY/I1zy3+IzupGA= X-Received: by 2002:a05:6512:3da4:b0:55b:8aff:9af3 with SMTP id 2adb3069b0e04-55b97abe56cmr421613e87.7.1754096922853; Fri, 01 Aug 2025 18:08:42 -0700 (PDT) MIME-Version: 1.0 References: <20250801015427.439511-1-reyuki@gnuweeb.org> <20250801015427.439511-2-reyuki@gnuweeb.org> In-Reply-To: From: reyuki Date: Sat, 2 Aug 2025 08:08:29 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXzgounf6szihdIMix7pakQXF-ZbxCHOeYNwTlUQ7ixAgxBERrrY_OlwFDE Message-ID: Subject: Re: [PATCH gwproxy v2 1/3] dnslookup: split common functionality and struct into net.c To: Alviro Iskandar Setiawan Cc: Ammar Faizi , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Sat, Aug 2, 2025 at 6:45=E2=80=AFAM Alviro Iskandar Setiawan wrote: > (( Nit: Change the var name from prt to port. The naming prt sounds weird= . )) Identifier port is already used, I will change it to default_port instead. > That port parameter addition should be a separate patch. So this > should be broken down into two commits: How to split an existing commit into a separate one? - git rebase -i base-commit - - make changes - create new commit here? -- Ahmad Gani