From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <reyuki@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS,
	URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no
	version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1757143354;
	bh=V+MxB6KLtCv2slPvbTd/7h2i1zcLoavipH7kvB/poBI=;
	h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
	 To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From:
	 Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date:
	 Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type:
	 Content-Transfer-Encoding;
	b=hduIQqcKteVQGXu8eRwxiqPYr+uqXXk+gohB1vrAluPu9DhVpx9VxxWL41wXwkQeU
	 QOEsYwgN0bsk3FHEySA35lAWBTeNRDKzRhOSxdH9OERDPPO92Teto/JH0kTNPFlU9I
	 6JNX7B/cOas4xPoxaKULcbiuGi+yvXzB4L07fwnrPnfkfWjPU2yNVIftVs3YGd/8Pf
	 U1VjL1o9I2s2vJeUM/Epo4Je4IiU6HLjdsvkUjBvOfaNXQvAEPg/Yo6E+q16QgUVB/
	 +jytgZotKacPP6RkIiFMHzAcdI+IjmJlbRQUvQYJD2dX1Jl7jgeGLm46K5InGXjaLI
	 rrc9HEbgLStsQ==
Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 1785D31279FE
	for <gwml@vger.gnuweeb.org>; Sat,  6 Sep 2025 07:22:34 +0000 (UTC)
Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-333f901b2d2so28876511fa.2
        for <gwml@vger.gnuweeb.org>; Sat, 06 Sep 2025 00:22:34 -0700 (PDT)
X-Forwarded-Encrypted: i=1; AJvYcCVFxSks/rXgzoFHjZvtwU32AlxG/5ujL1Eld9rkw7e1YkdeiknAE4+YBGJwRr72ZZaUKCd3@vger.gnuweeb.org
X-Gm-Message-State: AOJu0YyAsZTYOM+M7BVsaov/u/EVB6fjOP0OG0IKO92e0VZHpQbHBD8D
	zWXAT2cSLkbM3o8TNV4/5yZ36pAE0aNxmqdut0XTVvxZM20T6BJukch1Tb+HQVBsWqSIcMMl2HS
	qShaXYstaxXpxTZ/SYDFfRk8Aq16hDO8=
X-Google-Smtp-Source: AGHT+IGoi1O6UWDfKUpDQ9OMEV2ODdB6/FTvs7nzOHMuqo8aAv3uUf3pADfY/gLLyekSrB7r0haoC/1ClsUxd3U9ndQ=
X-Received: by 2002:a05:651c:221b:b0:336:94ec:5d16 with SMTP id
 38308e7fff4ca-33b5cfd0e7amr3633991fa.22.1757143353311; Sat, 06 Sep 2025
 00:22:33 -0700 (PDT)
MIME-Version: 1.0
References: <20250829075557.598176-1-reyuki@gnuweeb.org> <20250829075557.598176-3-reyuki@gnuweeb.org>
 <CAOG64qN+BXH0S5YTzBrgY4JAJPd-TSDpiOd8YSirU=BA0hUy2Q@mail.gmail.com> <CAOG64qP0n8k+1bUs0heZC8vMSs_fH1RKTDdbqm2EcqZ1xeZJJw@mail.gmail.com>
In-Reply-To: <CAOG64qP0n8k+1bUs0heZC8vMSs_fH1RKTDdbqm2EcqZ1xeZJJw@mail.gmail.com>
From: Ahmad Gani <reyuki@gnuweeb.org>
Date: Sat, 6 Sep 2025 14:21:56 +0700
X-Gmail-Original-Message-ID: <CAADvAgr1MpDi93+LEmW6N1U1ckNh_LhacG5axap3sT7VP=4G=w@mail.gmail.com>
X-Gm-Features: Ac12FXwA67XZ8hBVHgP4EeqW_cNCFh3sDlnuBjZhZSmIf8N9E2KMG0fErUBaAcM
Message-ID: <CAADvAgr1MpDi93+LEmW6N1U1ckNh_LhacG5axap3sT7VP=4G=w@mail.gmail.com>
Subject: Re: [PATCH gwproxy v8 2/2] gwproxy: refactor code base to add
 experimental raw DNS backend
To: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>, "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <gwml.vger.gnuweeb.org>

On Sat, Sep 6, 2025 at 2:14=E2=80=AFPM Alviro Iskandar Setiawan wrote:
> On Fri, Sep 5, 2025 at 11:26=E2=80=AFPM Alviro Iskandar Setiawan wrote:
> > > +       if (w->ctx->cfg.use_raw_dns) {
> > > +#ifdef CONFIG_RAW_DNS
> > > +       arm_poll_for_raw_dns_query(w, gcp);
> > > +
> > > +       r =3D __sys_epoll_ctl(w->ep_fd, EPOLL_CTL_ADD, gde->udp_fd, &=
ev);
> > >         if (unlikely(r))
> > > -               return r;
> > > +               return (int)r;
> > > +#endif
> > > +       } else {
> >
> > Bad indentation.
>
> Back to this section. Apart from that, the
> arm_poll_for_raw_dns_query() call here does not seem to care about
> what happens in __sys_sendto(). What if it fails?

Oops, apparently I forgot to add the error checking on that.

I guess if it returns an error, just drop the query and close the
proxy session (?)