Re: [PATCH gwproxy v3 6/9] dnsparser: Fix serialize_answ function

[Ahmad Gani <reyuki@gnuweeb.org>]

On Tue, Aug 5, 2025 at 8:04 PM Ammar Faizi wrote:
> On Tue, Aug 05, 2025 at 07:47:38PM +0700, Ahmad Gani wrote:
> > By the way, I have another question. If a patch appears to be bug-free and
> > gets applied but later turns out to have a bug, will the fix be included in
> > the problematic commit found by git bisect or added as a new commit that
> > refers to the original one? I assume the latter makes more sense, since
> > it preserves the commit history for other contributors.
>
> If the patch has been applied, it's already set in stone and should not
> be rebased because someone else might have pulled it (which will break
> the hash chain in the git history, just like a blockchain, it's
> immutable once it's distributed all over the world).
>
> The fix should be submitted as a new patch with a Fixes tag with at
> least the first 12 chars of the first SHA1 commit hash and followed by
> its full subject line.
>
> For example:
> https://patchwork.kernel.org/project/netdevbpf/patch/20250801190310.58443-1-ammarfaizi2@gnuweeb.org/

Thanks — that was a really helpful explanation!

--
Ahmad Gani