From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=new2025; t=1754399564; bh=IjTz7IJ8I5z9SPZZeI8gcVpW5A4sIkejM52CFn2aYpo=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=ViicFHE3Q7F3NuwPKUmM6sWpfe4dQ5AD/H5jo/RBZ+FSHHn5xseNleJ2CqLNmcAdg m3Iv2+mxamEy9a8k27zYdfq2pga8EttMHLYXiXQbzea/pXzCmVatopJm/J0kfBEbB7 0BW8bvQS9/veVPgXmqVF24ChsiFf/0m/4SbakZoA7yerBJkZKr/4xOzHReyu2KQ+Rc aRe5cWsTF8tROIruebJaAhKxEVDCy99oHfGEzXxlszsl9eCUH/00FuJVQ/Q7IowTMn EICrNb5LNWbxVsk9kW4OJiBp4xgo0Ne4mgk+adnvx6bckshfvwPATD4YorMT4YTX+7 fJ7KlGTI2bFDQ== Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 69B1B312805C for ; Tue, 5 Aug 2025 13:12:44 +0000 (UTC) Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-55b82db8fd4so6039564e87.2 for ; Tue, 05 Aug 2025 06:12:44 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVY4z11MPbXqILTYXvMT5RG8hgMCfEe2ZUcTes53RQ+I+y108J/8mFg1xnqRy+e5XFTILqw@vger.gnuweeb.org X-Gm-Message-State: AOJu0YwM0bKihR2OLY6qEyzXW+C0CvL2T2CEmKnnO52hilWCCwK6zNis wkFIfdIKazZHDdKKuTJLElF0+5BR5zZr3qoJpqXTE+u2jMlkuEkLfrqQ/M78XzL5XnV/by3EMUC +P4ul9hW695RpWJdj8eM/hPmDipzm27g= X-Google-Smtp-Source: AGHT+IHcbyNJe1w+EMOSnqxJ7gRSCsE8WtxI5eMa2SMdC2JqqNRhuV/rIPHa2/bV4X+qtfxVcCNPeC+iaham8aMGUP0= X-Received: by 2002:a05:6512:2390:b0:553:3172:1c23 with SMTP id 2adb3069b0e04-55b97ac4559mr4274902e87.17.1754399563742; Tue, 05 Aug 2025 06:12:43 -0700 (PDT) MIME-Version: 1.0 References: <20250805064933.109080-1-reyuki@gnuweeb.org> <20250805064933.109080-7-reyuki@gnuweeb.org> In-Reply-To: From: Ahmad Gani Date: Tue, 5 Aug 2025 20:12:06 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXyVsCo2rGHz12J9xi_Au3Hkqg31q1_NuwPcQeFwZzTw5ZQ9rSlU6p0gTbI Message-ID: Subject: Re: [PATCH gwproxy v3 6/9] dnsparser: Fix serialize_answ function To: Ammar Faizi Cc: Alviro Iskandar Setiawan , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Tue, Aug 5, 2025 at 8:04=E2=80=AFPM Ammar Faizi wrote: > On Tue, Aug 05, 2025 at 07:47:38PM +0700, Ahmad Gani wrote: > > By the way, I have another question. If a patch appears to be bug-free = and > > gets applied but later turns out to have a bug, will the fix be include= d in > > the problematic commit found by git bisect or added as a new commit tha= t > > refers to the original one? I assume the latter makes more sense, since > > it preserves the commit history for other contributors. > > If the patch has been applied, it's already set in stone and should not > be rebased because someone else might have pulled it (which will break > the hash chain in the git history, just like a blockchain, it's > immutable once it's distributed all over the world). > > The fix should be submitted as a new patch with a Fixes tag with at > least the first 12 chars of the first SHA1 commit hash and followed by > its full subject line. > > For example: > https://patchwork.kernel.org/project/netdevbpf/patch/20250801190310.58443= -1-ammarfaizi2@gnuweeb.org/ Thanks =E2=80=94 that was a really helpful explanation! -- Ahmad Gani