public inbox for [email protected]
 help / color / mirror / Atom feed
From: Kiizuha <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: "GNU/Weeb Mailing List" <[email protected]>
Subject: Re: [PATCH v1 06/11] Add traceback to get the error detail
Date: Mon, 18 Jul 2022 19:24:07 +0700	[thread overview]
Message-ID: <CAB4P+aNL+-BZ-dqdC+WUXnjcaeTmVXuV7mreWs3mnNBX_kXr=A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>

>
> Please give the reason of why do you make changes in this patch.
>
> That patch is not trivial as it has a lengthy discussion background
> story. It's something that needs an explanation. Not an empty body
> like that.
>
> A good commit message should explain "WHY" such a change is
> necessary.
>
> Maybe you can write it like this:
>
>      daemon: Use traceback.format_exc() to get the error detail
>
>      `print(f"[__run]: Error: {e}")` doesn't give enough information for
>      debugging because it doesn't show the traceback, files, line numbers,
>      etc. It only shows the error message raised by an exception. This is
>      severely lacking and very bad for debugging experience.
>
>      Use `traceback.format_exc()` instead to get a better log because it
>      shows a complete traceback of the error.
>
>      Signed-off-by: Your Name <[email protected]>
>
> Improve it yourself if needed.
>

Ok, I will do it. I just forget to check the git log and it doesn't
have a description to explain WHY, I will improve any commit in the
future. Thanks for reminding me.

  reply	other threads:[~2022-07-18 12:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18 11:19 [PATCH v1 00/11] Plan to redesign code Muhammad Rizki
2022-07-18 11:19 ` [PATCH v1 01/11] Fix __send_patch_msg function parameter Muhammad Rizki
2022-07-18 12:45   ` Ammar Faizi
2022-07-18 11:19 ` [PATCH v1 02/11] Fix import problem Muhammad Rizki
2022-07-18 11:19 ` [PATCH v1 03/11] Add default temporary directory Muhammad Rizki
2022-07-18 11:31   ` Ammar Faizi
2022-07-18 11:20 ` [PATCH v1 04/11] Move the Telegram bot session into the storage directory Muhammad Rizki
2022-07-18 11:20 ` [PATCH v1 05/11] daemon: Fix raw lore URL on the inline keyboard button Muhammad Rizki
2022-07-18 11:20 ` [PATCH v1 06/11] Add traceback to get the error detail Muhammad Rizki
2022-07-18 11:27   ` Ammar Faizi
2022-07-18 12:24     ` Kiizuha [this message]
2022-07-18 11:20 ` [PATCH v1 07/11] Re-design send email message to Telegram Muhammad Rizki
2022-07-18 12:49   ` Ammar Faizi
2022-07-18 11:20 ` [PATCH v1 08/11] Move ____send_patch_msg Muhammad Rizki
2022-07-18 11:20 ` [PATCH v1 09/11] Move prepare for patch and clean up patch functions Muhammad Rizki
2022-07-18 11:20 ` [PATCH v1 10/11] Create fix_utf8_chars function Muhammad Rizki
2022-07-18 11:20 ` [PATCH v1 11/11] Recode some codes Muhammad Rizki
2022-07-18 11:33   ` Ammar Faizi
2022-07-18 11:28 ` [PATCH v1 00/11] Plan to redesign code Ammar Faizi
2022-07-18 11:34 ` Ammar Faizi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAB4P+aNL+-BZ-dqdC+WUXnjcaeTmVXuV7mreWs3mnNBX_kXr=A@mail.gmail.com' \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox