From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, OBFU_UNSUB_UL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by gnuweeb.org (Postfix) with ESMTPS id B3E707E257 for ; Mon, 18 Jul 2022 12:24:22 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=AfDM7CAq; dkim-atps=neutral Received: by mail-ed1-f44.google.com with SMTP id k30so15000127edk.8 for ; Mon, 18 Jul 2022 05:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mgj9plof5PNn7a07y36uvPqYfgzBftKmcGgKdp3EcUw=; b=AfDM7CAqYVshBttok4rnDq/GGD/Jlichf/8WnVU13wSB4j5DXpFFqdLcjcxzyW8Gd6 zN9IzFj126uZwaRAv2OBc3GDvYtOERQ0AN8tIF5q6WoK+wA2aC0qvCMIlyjPR9SBmQFd SI11lw5SY6/0ofvAT8oLCgvZpXEcLWS8+8k0sPEGNjKh1b1Pdz8Msk+bPM0weoVOB3ed n8W2Qgke47HudHkkOIMF7O1IaJaOArBckwIMQ6Zypxgxgp1EKGZz0YLpP8JXCh3oNXSF HjLB0+7RjYv5CT1W1RVWHfJUOszZaMs4swrDcUaAZuy70ZM8/G/ziDH9+e9bKYZ++HZ6 CXDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mgj9plof5PNn7a07y36uvPqYfgzBftKmcGgKdp3EcUw=; b=cvV7fnDLVO6OrEpRFaax3QGRiP6sHlkHb5AwD5laOI/RietZJ+YhRtZnLfIzivaWkn oByEAXO66lT8xHAQU7qidXUurazMswJmiLl6Do9Oqc9bYB1v2vi2bds8jorKW/HIZKL7 QRJL5e0sc2zEKar/lr2Z1+Ryjmq97kevQCK/+5RfAoghaj4g8FI0+bYiI2xgOW8liu9/ J5wO6Cbe0A0ixEEU66+25hSKOLVAvs9lmyFxU046xEM3+cKjh3EKOII93THVNlXGQZ0z 47DhYd3/czc8TFaOuEafTDAfkI52VJnY1HYaXx1oRXxSIyQ9NngvFQk0QNxcGRU+ZT3V EIug== X-Gm-Message-State: AJIora9PjTrX2KlAAnIkDnylCiNH3omb3MRRbZnUqqB4DcdxEUp19FOt Sm9064YokT3y6NL3PrvdQsZXg/vv6w2O4CVNyIvcAqXzP99Z/g== X-Google-Smtp-Source: AGRyM1ul+gwj1mkJHlHelwiqQ/vOy3UcnRlaaHVYvy2q7NhL4aZSXQyn3tFnehm1ySJCW41AmYCfWw0lKSdyTuNRbII= X-Received: by 2002:a05:6402:51d1:b0:43a:8154:babe with SMTP id r17-20020a05640251d100b0043a8154babemr37368824edd.26.1658147060935; Mon, 18 Jul 2022 05:24:20 -0700 (PDT) MIME-Version: 1.0 References: <20220718112007.792-1-riskimuhammmad1@gmail.com> <20220718112007.792-7-riskimuhammmad1@gmail.com> <759288de-6f44-12bf-434b-708f42f5a825@gnuweeb.org> In-Reply-To: <759288de-6f44-12bf-434b-708f42f5a825@gnuweeb.org> From: Kiizuha Date: Mon, 18 Jul 2022 19:24:07 +0700 Message-ID: Subject: Re: [PATCH v1 06/11] Add traceback to get the error detail To: Ammar Faizi Cc: "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" List-Id: > > Please give the reason of why do you make changes in this patch. > > That patch is not trivial as it has a lengthy discussion background > story. It's something that needs an explanation. Not an empty body > like that. > > A good commit message should explain "WHY" such a change is > necessary. > > Maybe you can write it like this: > > daemon: Use traceback.format_exc() to get the error detail > > `print(f"[__run]: Error: {e}")` doesn't give enough information for > debugging because it doesn't show the traceback, files, line numbers, > etc. It only shows the error message raised by an exception. This is > severely lacking and very bad for debugging experience. > > Use `traceback.format_exc()` instead to get a better log because it > shows a complete traceback of the error. > > Signed-off-by: Your Name > > Improve it yourself if needed. > Ok, I will do it. I just forget to check the git log and it doesn't have a description to explain WHY, I will improve any commit in the future. Thanks for reminding me.