From: Doug Anderson <[email protected]>
To: Stephen Boyd <[email protected]>
Cc: Dmitry Torokhov <[email protected]>,
LKML <[email protected]>,
[email protected], [email protected],
Krzysztof Kozlowski <[email protected]>,
Rob Herring <[email protected]>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<[email protected]>, Benson Leung <[email protected]>,
Guenter Roeck <[email protected]>,
Hsin-Yi Wang <[email protected]>,
"Joseph S. Barrera III" <[email protected]>
Subject: Re: [PATCH v3 1/2] dt-bindings: google,cros-ec-keyb: Introduce switches only compatible
Date: Tue, 3 May 2022 08:09:04 -0700 [thread overview]
Message-ID: <CAD=FV=V8kfRYidvQRmx_XmGm8X3XHR_GxTkKvxkqUHdqJ5CMNg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
Hi,
On Mon, May 2, 2022 at 9:22 PM Stephen Boyd <[email protected]> wrote:
>
> @@ -113,3 +135,56 @@ examples:
> /* UP LEFT */
> 0x070b0067 0x070c0069>;
> };
> +
> + - |
> + keyboard-controller {
> + compatible = "google,cros-ec-keyb-switches", "google,cros-ec-keyb";
> + /* Matrix keymap properties are allowed but ignored */
nit: s/allowed/required/
This now looks reasonable and well explained to me.
Reviewed-by: Douglas Anderson <[email protected]>
next prev parent reply other threads:[~2022-05-03 15:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 4:22 [PATCH v3 0/2] Input: cros-ec-keyb: Better matrixless support Stephen Boyd
2022-05-03 4:22 ` [PATCH v3 1/2] dt-bindings: google,cros-ec-keyb: Introduce switches only compatible Stephen Boyd
2022-05-03 15:09 ` Doug Anderson [this message]
2022-05-03 4:22 ` [PATCH v3 2/2] Input: cros-ec-keyb - skip keyboard registration w/o cros-ec-keyb compatible Stephen Boyd
2022-05-03 15:09 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=V8kfRYidvQRmx_XmGm8X3XHR_GxTkKvxkqUHdqJ5CMNg@mail.gmail.com' \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
[email protected] \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox