From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by gnuweeb.org (Postfix) with ESMTPS id 377F781660 for ; Fri, 18 Nov 2022 16:09:19 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=dMWmpFbS; dkim-atps=neutral Received: by mail-il1-f182.google.com with SMTP id r2so2723493ilg.8 for ; Fri, 18 Nov 2022 08:09:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Objxi5E3Yaq/x6Gp7+gu3eLoVEmBCFLi+SQ4Itr/rJc=; b=dMWmpFbSY+9yu5DRZ7dmqi/uU8lzGWD16JzIVsW2oMMMWmbDqY3Nu4dHsKTekckGxR 4t+xAHwRnT7VjSrvW+EZXfoYjnF30Cedo15Bbs37S+oAw+GvDK8NQH2X5ujaBOzKhNW4 /9VEgqTpaRuLZiMEPKG+wwcEGiPuUVcjaNAlLZBS4dLzJ+FVLUTMfpu01ZYZzfHSocq1 rBNwIHhEVQUHqEknmTQrAsufEiyfPr3uxKMPdxHchtiiQTuYetWHFgwiQ4Rq+4Dtvl1v AxwIFuXPaCyHQl73imBOXtPtL0AQvhHLJFeRI36d5sFW2Ie+gXxpaCvfXM8AdpbihyC1 ynUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Objxi5E3Yaq/x6Gp7+gu3eLoVEmBCFLi+SQ4Itr/rJc=; b=dgDBsKl0F6gslmQ+a7HZf64u9E3UCOlKks2fJ8EHUOVzYWtYvWvIzrjTEAPEUIFwU9 oRUd2vUYNS+a2r2cW8GpS9EaHN1C8kp0PMZmG15qZ0XjuBo0J3go2Q8MVJA2DfzhpMf9 0n/16/3enieTKj2a6DmnAnFXiE7TruktEvlngTRlgyD2YNYKYGOY2OxXcLHonBjopZ9E XfPLdZal5NOJ9WFquUR9k3wPOR2khhos7GRc9H2ovn0zSzTn33FOxzorJew/FlwemOt6 Ngi7ZKuLCNbP7kgrUdNyKYnAwpDyV0ZMn16UjxN2qY2KJosN3xH9cGamFlmw1ZyJyyhv 510A== X-Gm-Message-State: ANoB5pkPgORUFi/MA+KpHuSBo98P5F4SGVpL2dndOUSc/D+v4X2fcGlh /jpim09cp0rNW49wO0ejfYMZXNAA8kqSCkvK/2I= X-Google-Smtp-Source: AA0mqf4VcEC7fAvoBdmDV4agp9WoGI3BFhbYelg/5A1YZNgPStiXqmQyCoj4QkFu0f2DS0GrGR0JSI2YPsE+fCEUOpo= X-Received: by 2002:a92:6b03:0:b0:302:55d5:8808 with SMTP id g3-20020a926b03000000b0030255d58808mr3476771ilc.152.1668787758131; Fri, 18 Nov 2022 08:09:18 -0800 (PST) MIME-Version: 1.0 References: <20221117172729.2302627-1-ammarfaizi2@gnuweeb.org> In-Reply-To: From: Kyoko Senpai Date: Fri, 18 Nov 2022 23:09:07 +0700 Message-ID: Subject: Re: Fix data corruption bug To: Alviro Iskandar Setiawan Cc: Ammar Faizi , Muhammad Rizki , Dina Maulina , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" List-Id: On Fri, Nov 18, 2022 at 9:31 AM Alviro Iskandar Setiawan wrote: > On Fri, Nov 18, 2022 at 12:27 AM Ammar Faizi wrote: > > From: Ammar Faizi > > Subject: [PATCH] chnet: Fix data corruption when a read operation is pending > > > > When a read operation is pending, the @read_ret_ variable has to be > > set to -EINPROGRESS. The current CHNetDelegate::__Read() method > > doesn't do that. This situation makes the caller abort the request > > because it doesn't see -EINPROGRESS from the return value. This bug > > is reproducible on a slow network connection where __Read() > > operation often results in a pending state. > > > > This bug is introduced in commit 77bbcc903899 ("chnet: Completely > > refactor again"). > > > > Fixes: 77bbcc903899 ("chnet: Completely refactor again") > > Signed-off-by: Ammar Faizi > > Reviewed-by: Alviro Iskandar Setiawan Reviewed-by: Gilang Fachrezy