From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>,
"GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v7 0/2] Initial work on integration of DNS parser lib in gwproxy
Date: Fri, 29 Aug 2025 14:45:25 +0700 [thread overview]
Message-ID: <CAFBCWQJT3PVuw3k_mM3tv72AC6ONA_5N9EPiWuvYNfB-vyeCRQ@mail.gmail.com> (raw)
In-Reply-To: <CAADvAgq7GbxJymsWYQWBEfXy_kX5f8pmZfb6iRTucw9vZsx6Kg@mail.gmail.com>
On Fri, Aug 29, 2025 at 2:40 PM Ahmad Gani wrote:
> Cool. it can detect something that compiler didn't catch:
Yeah, that's great. But note that you don't need to address all
warnings. That long printf() call is totally fine here. And it's
better to be written that long.
I am not sure why it is yelling about ENOSYS. It does not make much
sense to warn that for gwproxy. So you can ignore some warnings. My
primary complaint was the whitespace error.
--
Ammar Faizi
next prev parent reply other threads:[~2025-08-29 7:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 3:36 [PATCH gwproxy v7 0/2] Initial work on integration of DNS parser lib in gwproxy Ahmad Gani
2025-08-29 3:36 ` [PATCH gwproxy v7 1/2] dnsparser: Add dns parser code Ahmad Gani
2025-08-29 4:39 ` Ammar Faizi
2025-08-29 3:36 ` [PATCH gwproxy v7 2/2] gwproxy: refactor code base to add experimental raw DNS backend Ahmad Gani
2025-08-29 4:36 ` Ammar Faizi
2025-08-29 7:35 ` Ahmad Gani
2025-08-29 7:39 ` Ammar Faizi
2025-08-29 4:36 ` [PATCH gwproxy v7 0/2] Initial work on integration of DNS parser lib in gwproxy Ammar Faizi
2025-08-29 6:57 ` Ahmad Gani
2025-08-29 7:22 ` Ammar Faizi
2025-08-29 7:30 ` Ammar Faizi
2025-08-29 7:39 ` Ahmad Gani
2025-08-29 7:45 ` Ammar Faizi [this message]
2025-08-29 7:36 ` Ammar Faizi
2025-08-29 7:51 ` Ahmad Gani
2025-08-29 8:00 ` Ammar Faizi
2025-08-29 8:06 ` Ahmad Gani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBCWQJT3PVuw3k_mM3tv72AC6ONA_5N9EPiWuvYNfB-vyeCRQ@mail.gmail.com \
--to=ammarfaizi2@gnuweeb.org \
--cc=alviro.iskandar@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
--cc=reyuki@gnuweeb.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox