From: Linus Torvalds <torvalds@linux-foundation.org>
To: Simon Horman <horms@kernel.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
Oliver Neukum <oneukum@suse.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Netdev Mailing List <netdev@vger.kernel.org>,
Linux USB Mailing List <linux-usb@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Armando Budianto <sprite@gnuweeb.org>,
gwml@vger.gnuweeb.org, stable@vger.kernel.org,
John Ernberg <john.ernberg@actia.se>
Subject: Re: [PATCH net v2] net: usbnet: Fix the wrong netif_carrier_on() call placement
Date: Wed, 6 Aug 2025 04:11:09 +0300 [thread overview]
Message-ID: <CAHk-=wh+bnqPjL=9oq3uEkyZ7WB8=F_QMOHsGjHLj98oYk-X3Q@mail.gmail.com> (raw)
In-Reply-To: <CAHk-=wjqL4uF0MG_c8+xHX1Vv8==sPYQrtzbdA3kzi96284nuQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
On Wed, 6 Aug 2025 at 01:40, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> And no, I didn't actually test that version, because I was hoping that
> somebody who actually knows this code better would pipe up.
Bah. Since I'm obviously horribly jetlagged, I decided to just test to
make sure I understand the code.
And yeah, the attached patch also fixes the problem for me and makes
more sense to me.
But again, it would be good to get comments from people who *actually*
know the code.
Linus
[-- Attachment #2: patch.diff --]
[-- Type: application/x-patch, Size: 956 bytes --]
next prev parent reply other threads:[~2025-08-06 1:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 19:03 [PATCH net v2] net: usbnet: Fix the wrong netif_carrier_on() call placement Ammar Faizi
2025-08-04 10:00 ` Simon Horman
2025-08-05 20:28 ` Simon Horman
2025-08-05 21:16 ` Ammar Faizi
2025-08-05 22:40 ` Linus Torvalds
2025-08-05 23:47 ` Jakub Kicinski
2025-08-05 23:57 ` Ammar Faizi
2025-08-12 20:57 ` John Ernberg
2025-08-05 23:56 ` Ammar Faizi
2025-08-06 0:05 ` Ammar Faizi
2025-08-06 1:11 ` Linus Torvalds [this message]
2025-08-06 1:54 ` Linus Torvalds
2025-08-07 1:37 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wh+bnqPjL=9oq3uEkyZ7WB8=F_QMOHsGjHLj98oYk-X3Q@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=gwml@vger.gnuweeb.org \
--cc=horms@kernel.org \
--cc=john.ernberg@actia.se \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
--cc=sprite@gnuweeb.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox