From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE, RCVD_IN_ZEN_BLOCKED_OPENDNS,SPF_PASS,URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 Authentication-Results: server-vie001.gnuweeb.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=google header.b=B9Il1xNc; dkim-atps=neutral Received: by server-vie001.gnuweeb.org (Postfix, from userid 1000) id 9721B3127C34; Wed, 6 Aug 2025 01:11:30 +0000 (UTC) Authentication-Results: server-vie001.gnuweeb.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.218.46; helo=mail-ej1-f46.google.com; envelope-from=torvalds@linuxfoundation.org; receiver= Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by server-vie001.gnuweeb.org (Postfix) with ESMTPS id 443AB3127C32 for ; Wed, 6 Aug 2025 01:11:29 +0000 (UTC) Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-af95ecfbd5bso548244566b.1 for ; Tue, 05 Aug 2025 18:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1754442688; x=1755047488; darn=vger.gnuweeb.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=d2GKUutMb+CTg/SBIA+X4H18S3n8qy8/RVR5pHccndQ=; b=B9Il1xNclysASssyJG9itgmHKSl9iCOa86PBUFtQwoAOGdIqQuUFoxBrgpqalPkpS3 /HJAfPhxWdxGG01C9TvR+jjb8g9HAyTkK3o9ullhQs81MbKECMIdYpfHX6NXTG8V4E/d WWgE0CYXw7qiE0U36mzJmwyN+A5b0hD/1ofOs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754442688; x=1755047488; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d2GKUutMb+CTg/SBIA+X4H18S3n8qy8/RVR5pHccndQ=; b=hDhXAYcOhy0Qq1FAzhpsTwNfB3Ru9H26c0tGnXYi7a8SAyRJex+sl5/+3+/8Evqchk 6K4eHL82yHCRl9x/XmIj/KYqzAN3NiJpST4MS6dykRyNS4Zj9wOKIvU08EIsdzrGAPVi ZTsIQJQOVHp+ISXPYpEdjvPHYuyt+CyHK0sH+AqLA1m4pivFEKtgKsOII9ov0YJJvocp JAqvrPUzkJD+FnCbghDGFlN/QD15aCqjBJZfPcN902PzGQ620DLyT3WWDB7PeXcy+Oeu Rmh5WRik0yP75kRvpYOaLipJHPK3R33KW6ntXj1uPwruDgWnxcHv4/65qKFcY4Emb+cp OsbQ== X-Forwarded-Encrypted: i=1; AJvYcCXsuFLpR3XvNmsQyshQbvzD0AYlC9uc5etb2StEkv9b0UN77uteDNh3YEpM7GQmGc0HwdZf@vger.gnuweeb.org X-Gm-Message-State: AOJu0YzlFs56gPaxkeUw6WghIOLPKQrevOs2CbyjRNMkKhBmivCT5ZnD UmFZZhEIKGdwtV9LIoPMrYHOmo41mxo0KAUYokTfs0qBdsiOHTosF9GbQiWFlQv/PbP3rQaowf1 b1cM3BORZDA== X-Gm-Gg: ASbGncuvFViXHsPBOGP50U1tLqftQyMeTP9Wn71sS92WWo2p4NRzHwrYpzNrhBNTuSe 2HaJTPD6ms7lzYD6vJeUtCH/kvWCnw96sewqKfC+mCmyo4hEBe/oBfHyUlqOGKS/egxzLpHAj1x rb4WfGlOYpUycOYbl+w/AJBWMODdl8TmbZum1hV7YjNiLZuyc9v6boxXRFTlq0vx43aWL/949IS n2gNqi7UxvnrzRZMIshsgyctFyTzl+uuQCeOM5TtQyiQ/pX3n9RGXWjw6uy2I9RlrSG4xKZbgn9 HFk3OO3tp34gKEZb/n+2jsJt+h7bBCrv/2WZo0qrbtjCfgP20nuqZaxPxBjRQgkWnyzSW+G5nx+ 6zVEr1wmK5wMrfS3UJjZHnVRV4+TBXX8LxENQgItuPNudHEYxGbcRu93SFvJ0YypPV+AFvxRZ X-Google-Smtp-Source: AGHT+IH9Mw9SIk1LXgtv7X7eZ+JlPALKs/N1XvpNwdSKAcaWoLrWs5vxKRAENvXw+maYRI45+Hr0/Q== X-Received: by 2002:a17:907:c1c:b0:af9:5e9a:b6a with SMTP id a640c23a62f3a-af990344c33mr83891966b.42.1754442688181; Tue, 05 Aug 2025 18:11:28 -0700 (PDT) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com. [209.85.218.45]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af91a0a3b58sm998421866b.58.2025.08.05.18.11.26 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Aug 2025 18:11:26 -0700 (PDT) Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-af95ecfbd5bso548239366b.1 for ; Tue, 05 Aug 2025 18:11:26 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXLfc3naoDk/0+j1JSIvwejqQEnlmVNoDDQElYh8Y05Q/XaYuLnS0IaI2AVBAtQxkvStldv@vger.gnuweeb.org X-Received: by 2002:a17:907:9703:b0:ae3:6651:58ba with SMTP id a640c23a62f3a-af9902dffaemr94719466b.35.1754442686168; Tue, 05 Aug 2025 18:11:26 -0700 (PDT) MIME-Version: 1.0 References: <20250801190310.58443-1-ammarfaizi2@gnuweeb.org> <20250804100050.GQ8494@horms.kernel.org> <20250805202848.GC61519@horms.kernel.org> In-Reply-To: From: Linus Torvalds Date: Wed, 6 Aug 2025 04:11:09 +0300 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXx151gZKxn5F0B-h1oNAfMmrkA84RTvsrxwBVO-1UWY7oBd7NqVoQGVGt8 Message-ID: Subject: Re: [PATCH net v2] net: usbnet: Fix the wrong netif_carrier_on() call placement To: Simon Horman Cc: Ammar Faizi , Oliver Neukum , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Greg Kroah-Hartman , Linux Netdev Mailing List , Linux USB Mailing List , Linux Kernel Mailing List , Armando Budianto , gwml@vger.gnuweeb.org, stable@vger.kernel.org, John Ernberg Content-Type: multipart/mixed; boundary="00000000000016f79a063ba80507" List-Id: --00000000000016f79a063ba80507 Content-Type: text/plain; charset="UTF-8" On Wed, 6 Aug 2025 at 01:40, Linus Torvalds wrote: > > And no, I didn't actually test that version, because I was hoping that > somebody who actually knows this code better would pipe up. Bah. Since I'm obviously horribly jetlagged, I decided to just test to make sure I understand the code. And yeah, the attached patch also fixes the problem for me and makes more sense to me. But again, it would be good to get comments from people who *actually* know the code. Linus --00000000000016f79a063ba80507 Content-Type: application/x-patch; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_mdz5fpf80 IGRyaXZlcnMvbmV0L3VzYi91c2JuZXQuYyB8IDYgKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgMyBp bnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3Vz Yi91c2JuZXQuYyBiL2RyaXZlcnMvbmV0L3VzYi91c2JuZXQuYwppbmRleCBhMzhmZmJmNGIzZjAu LjUxMWM0MTU0Y2Y3NCAxMDA2NDQKLS0tIGEvZHJpdmVycy9uZXQvdXNiL3VzYm5ldC5jCisrKyBi L2RyaXZlcnMvbmV0L3VzYi91c2JuZXQuYwpAQCAtMTEyMCw2ICsxMTIwLDkgQEAgc3RhdGljIHZv aWQgX19oYW5kbGVfbGlua19jaGFuZ2Uoc3RydWN0IHVzYm5ldCAqZGV2KQogCWlmICghdGVzdF9i aXQoRVZFTlRfREVWX09QRU4sICZkZXYtPmZsYWdzKSkKIAkJcmV0dXJuOwogCisJaWYgKHRlc3Rf YW5kX2NsZWFyX2JpdChFVkVOVF9MSU5LX0NBUlJJRVJfT04sICZkZXYtPmZsYWdzKSkKKwkJbmV0 aWZfY2Fycmllcl9vbihkZXYtPm5ldCk7CisKIAlpZiAoIW5ldGlmX2NhcnJpZXJfb2soZGV2LT5u ZXQpKSB7CiAJCS8qIGtpbGwgVVJCcyBmb3IgcmVhZGluZyBwYWNrZXRzIHRvIHNhdmUgYnVzIGJh bmR3aWR0aCAqLwogCQl1bmxpbmtfdXJicyhkZXYsICZkZXYtPnJ4cSk7CkBAIC0xMTI5LDkgKzEx MzIsNiBAQCBzdGF0aWMgdm9pZCBfX2hhbmRsZV9saW5rX2NoYW5nZShzdHJ1Y3QgdXNibmV0ICpk ZXYpCiAJCSAqIHR4IHF1ZXVlIGlzIHN0b3BwZWQgYnkgbmV0Y29yZSBhZnRlciBsaW5rIGJlY29t ZXMgb2ZmCiAJCSAqLwogCX0gZWxzZSB7Ci0JCWlmICh0ZXN0X2FuZF9jbGVhcl9iaXQoRVZFTlRf TElOS19DQVJSSUVSX09OLCAmZGV2LT5mbGFncykpCi0JCQluZXRpZl9jYXJyaWVyX29uKGRldi0+ bmV0KTsKLQogCQkvKiBzdWJtaXR0aW5nIFVSQnMgZm9yIHJlYWRpbmcgcGFja2V0cyAqLwogCQlx dWV1ZV93b3JrKHN5c3RlbV9iaF93cSwgJmRldi0+Ymhfd29yayk7CiAJfQo= --00000000000016f79a063ba80507--