From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE,SPF_PASS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 Authentication-Results: server-vie001.gnuweeb.org; dkim=pass (1024-bit key; unprotected) header.d=linux-foundation.org header.i=@linux-foundation.org header.a=rsa-sha256 header.s=google header.b=XqwagvWu; dkim-atps=neutral Received: by server-vie001.gnuweeb.org (Postfix, from userid 1000) id B0DFE3127C33; Wed, 6 Aug 2025 01:54:54 +0000 (UTC) Authentication-Results: server-vie001.gnuweeb.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.218.41; helo=mail-ej1-f41.google.com; envelope-from=torvalds@linuxfoundation.org; receiver= Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) by server-vie001.gnuweeb.org (Postfix) with ESMTPS id 3008F3127C31 for ; Wed, 6 Aug 2025 01:54:53 +0000 (UTC) Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-acb5ec407b1so918001966b.1 for ; Tue, 05 Aug 2025 18:54:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; t=1754445293; x=1755050093; darn=vger.gnuweeb.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=L1PkDCTaXOlCgVfN+O/OMDhLH2gXEH5igacRG1rqZxQ=; b=XqwagvWuCe3kCUCye14/lDp1hk49NpZIXhj0iF1ttR1seGjZqJUH1RHFlP5+0matpf sTw6Pu3DIw4d74s8QXWumI+gvGTVzkPYHFaFbF9vmGA4sexDJYw1EnS3gPl/BlCvoyRM XMNphm9+IDcXz12Zzsy+C/Xmks114cAvtgY/w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754445293; x=1755050093; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=L1PkDCTaXOlCgVfN+O/OMDhLH2gXEH5igacRG1rqZxQ=; b=dUJShKUbCsQeGWK+tFdK7gvfI1NqTRRzmCOI/SrrjLRhck1dU7rPM5vRZQoSOXWIZy h1FswGAExT+PVekwAHbMai+gvrEPkWevN64ETjPr7KrP3XFHSiYsKpKZ4mD1B2QpqSo2 rgixeWs9j9LtWVOkBlg/Av8ELZ8HyAnahftXcI8qQv87Z6qVL6IDukMIfvzJz49DKIMu wJOavHQEZfdfdBvTxcQ8zsJXpknhfr+bRoTpVX3pIBUbHBNTVIYNcPnFJByVSXcen6r+ /Z/XBYm6Mh+5lTj4UW3vRZZgqbPU6zfVcKFLltHQ3hEyhH4aMe63oWTumz0bg53M71RA KP7Q== X-Forwarded-Encrypted: i=1; AJvYcCXAfafWL4pRC0CjiojEM4wqCnFsnwyZCJDLfvAwRcT7iN7lVhTsKMDPot3jFotS2JaApx0a@vger.gnuweeb.org X-Gm-Message-State: AOJu0Yz1EyyUBqXVAkQaavVZtDFDxf9CiMUpnE2fSzmLn09HPP7TFRCO DIeelruj7GfBMUyVaRServW10203Ht8oOji6zAOAHWdDKX3OuL4xiN/YGy8ptPoWBjw7TH4h8YB bYPNKvF0c3Q== X-Gm-Gg: ASbGnctLNE+Y48kixA7w0OrryO/xpy8jUqgw8WIjQ7sO6Nf8JakJrXj4S3ypaLcncF2 vKlogDnS+gDw9V09wJCc38vzsqItmbWJZeHbBkoULuzCCYOQC9wL5vPu6JSCcTH5dIbD7QKzdMK wjyFnaZmLBmh6J9ENFRUsWSFZbyiY7ZRCLYEdr4yQppRn+B4V6v1rX20lEfFGfi7J96iadg5lrm tjeqEEeLNOjgSTyS2wr5YCgykR3vUKWeETGqWaK/E+/yETeAiLHDxBsxXYKKOj4pYYA7W+W0+8i 6eXsMIDGPfdTBg0+lkyoE8mBfIqBCZYk6gWKlRMHFbYq83a95QicLFfyz7/wh0D4uwVADKphwOT eUFf2+ggYOjZOBhX9ODttkVzmky2Q5rfeYYmFYQQinGByW8SD3hmomxAO2me1VmAPyl/N+YVa X-Google-Smtp-Source: AGHT+IF69Hqt3qlMQ1pCbqUUU5TONYUhO3MGLIwZ7Cof1EB+0BQ9BlHnMt99GLPWtRyyMaQrgfMGzw== X-Received: by 2002:a17:907:72cd:b0:af9:3116:e110 with SMTP id a640c23a62f3a-af9904a25f9mr104416566b.58.1754445293170; Tue, 05 Aug 2025 18:54:53 -0700 (PDT) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com. [209.85.208.41]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-af91a0771basm994558266b.29.2025.08.05.18.54.52 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Aug 2025 18:54:52 -0700 (PDT) Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-615460d9897so7293767a12.0 for ; Tue, 05 Aug 2025 18:54:52 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCX2T3/4pyy2Koxrg8l7hX/SW21TqHFMd34oKqKycfU5xKixn7Ub8p3iLv5HVPlqGchXGjmX@vger.gnuweeb.org X-Received: by 2002:aa7:d64b:0:b0:608:6501:6a1f with SMTP id 4fb4d7f45d1cf-617960b2169mr747725a12.1.1754445292221; Tue, 05 Aug 2025 18:54:52 -0700 (PDT) MIME-Version: 1.0 References: <20250801190310.58443-1-ammarfaizi2@gnuweeb.org> <20250804100050.GQ8494@horms.kernel.org> <20250805202848.GC61519@horms.kernel.org> In-Reply-To: From: Linus Torvalds Date: Wed, 6 Aug 2025 04:54:36 +0300 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXyVcowt5QK4YaVtsfApiqsjcc5RnE4u3G8HT-dXMHsAGYoNHxft3oIBLvY Message-ID: Subject: Re: [PATCH net v2] net: usbnet: Fix the wrong netif_carrier_on() call placement To: Simon Horman Cc: Ammar Faizi , Oliver Neukum , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Greg Kroah-Hartman , Linux Netdev Mailing List , Linux USB Mailing List , Linux Kernel Mailing List , Armando Budianto , gwml@vger.gnuweeb.org, stable@vger.kernel.org, John Ernberg Content-Type: text/plain; charset="UTF-8" List-Id: On Wed, 6 Aug 2025 at 04:11, Linus Torvalds wrote: > > And yeah, the attached patch also fixes the problem for me and makes > more sense to me. Ok, crossed emails because I was reading things in odd orders and going back to bed trying to get over jetlag. Anyway, I've applied Ammar's v3 that ended up the same patch that I also tested, Linus