From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,ENV_AND_HDR_SPF_MATCH, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by gnuweeb.org (Postfix) with ESMTPS id 40B438093C for ; Tue, 11 Oct 2022 20:42:07 +0000 (UTC) Authentication-Results: gnuweeb.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20210112 header.b=QY4rW3Oh; dkim-atps=neutral Received: by mail-wr1-f54.google.com with SMTP id bu30so23352804wrb.8 for ; Tue, 11 Oct 2022 13:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JPaqaQpCA6j/bQzuqNFHI2KUkN19JR0/BVhLmboxsZY=; b=QY4rW3OhBtMg926stweYItI2vbTgWXOe80hyUmMtTkSz5Kamf7HDDzSQwLhYqv7TOV 0IaI2m6mieI3JRT3GlAUL+K0fqyGSqYVy8DL+t8Kauh90qK9oZBDHMI0j1hUH64GMJOn snvvvSPufjKC02q5YMJgKQEGV5xmhuHx1fdh1JJmpoc+Jcqy9pkkH54Bbm2w1r1uokm2 BZnyuAkQGN5lSyJFnSe7PHTOQWf59R8UIW6KshBH++AcGs2KlOFkDHqYeCs/CSyMJt70 EneAPTo15FKUNdhVU7MeRSD0LH0b/y9N5NdQkt9mLaM7HeOZiEWptcvGVuPBxEsiXBLF YNcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JPaqaQpCA6j/bQzuqNFHI2KUkN19JR0/BVhLmboxsZY=; b=337zUEayl67VUbSvXaz+U3LWVbXYOBKpyuugpPU4EQQIInrOEt9/mm88T4O3QP+qkZ YMOZYAXJhz1rRnbnXEArWXCluF4hmxPvc8AvDY1YEiNN8XTfPsFWN35pv0Mf2YvKRAbP sk6t3L6y1s2tA6f0CXHTk6QhFRcHWdoQKonHyXl+8w10kEZs+Bv53xbhiSHa73G25jQa q07tMihRsavUo8YrdlRtzxtqyO4FnZYqjR9VSp7Hvin8kvmYgsFEfxh7cphmb/UqASTL ueQSp5ESp2WD1SuZwE8X8iPfU8cLQ3sTVqQ292rERbo7hugkfN5mbZTrNJWVgbp5auMB CC7Q== X-Gm-Message-State: ACrzQf1c97RHSjl5sTCTSnxrBl+YgCeySh1M63S69Ic7Yo8xA+gGOsRx ahY8nrAt5j8bSCMNTs2jE9faqSujQ+ePdE0ZxCuk7A== X-Google-Smtp-Source: AMsMyM4GGtyfQs3Poz9WXTx8MGyTwsq+hIA/zVW61KaT8VPQ00EMgHLxgyWuXcC/ltkImhrsg6rwM/fu6Gmxkf3EkAI= X-Received: by 2002:a5d:5a82:0:b0:224:f744:1799 with SMTP id bp2-20020a5d5a82000000b00224f7441799mr16035416wrb.582.1665520925453; Tue, 11 Oct 2022 13:42:05 -0700 (PDT) MIME-Version: 1.0 References: <202210120440.qmxr3KCs-lkp@intel.com> In-Reply-To: <202210120440.qmxr3KCs-lkp@intel.com> From: Yosry Ahmed Date: Tue, 11 Oct 2022 13:41:29 -0700 Message-ID: Subject: Re: [ammarfaizi2-block:tj/cgroup/for-next 3/5] kernel/cgroup/cgroup.c:6765: warning: expecting prototype for cgroup_get_from_fd(). Prototype was for cgroup_v1v2_get_from_fd() instead To: kernel test robot Cc: kbuild-all@lists.01.org, Ammar Faizi , "GNU/Weeb Mailing List" , linux-kernel@vger.kernel.org, Tejun Heo Content-Type: text/plain; charset="UTF-8" List-Id: On Tue, Oct 11, 2022 at 1:39 PM kernel test robot wrote: > > tree: https://github.com/ammarfaizi2/linux-block tj/cgroup/for-next > head: 8248fe413216732f98563e8882b6c6ae617c327b > commit: a6d1ce5951185ee91bbe6909fe2758f3625561b0 [3/5] cgroup: add cgroup_v1v2_get_from_[fd/file]() > config: m68k-randconfig-r005-20221010 > compiler: m68k-linux-gcc (GCC) 12.1.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/ammarfaizi2/linux-block/commit/a6d1ce5951185ee91bbe6909fe2758f3625561b0 > git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block > git fetch --no-tags ammarfaizi2-block tj/cgroup/for-next > git checkout a6d1ce5951185ee91bbe6909fe2758f3625561b0 > # save the config file > mkdir build_dir && cp config build_dir/.config > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash kernel/cgroup/ > > If you fix the issue, kindly add following tag where applicable > | Reported-by: kernel test robot > > All warnings (new ones prefixed by >>): > > kernel/cgroup/cgroup.c:6251: warning: Function parameter or member 'f' not described in 'cgroup_get_from_file' > >> kernel/cgroup/cgroup.c:6765: warning: expecting prototype for cgroup_get_from_fd(). Prototype was for cgroup_v1v2_get_from_fd() instead > kernel/cgroup/cgroup.c:6783: warning: Function parameter or member 'fd' not described in 'cgroup_get_from_fd' > > > vim +6765 kernel/cgroup/cgroup.c > > 16af439645455fb kernel/cgroup.c Tejun Heo 2015-11-20 6754 > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6755 /** > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6756 * cgroup_get_from_fd - get a cgroup pointer from a fd Ugh I forgot to update this line in the comment. Tejun, is this patchable in place or should I send a patch for this? > a6d1ce5951185ee kernel/cgroup/cgroup.c Yosry Ahmed 2022-10-11 6757 * @fd: fd obtained by open(cgroup_dir) > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6758 * > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6759 * Find the cgroup from a fd which should be obtained > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6760 * by opening a cgroup directory. Returns a pointer to the > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6761 * cgroup on success. ERR_PTR is returned if the cgroup > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6762 * cannot be found. > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6763 */ > a6d1ce5951185ee kernel/cgroup/cgroup.c Yosry Ahmed 2022-10-11 6764 struct cgroup *cgroup_v1v2_get_from_fd(int fd) > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 @6765 { > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6766 struct cgroup *cgrp; > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6767 struct file *f; > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6768 > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6769 f = fget_raw(fd); > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6770 if (!f) > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6771 return ERR_PTR(-EBADF); > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6772 > a6d1ce5951185ee kernel/cgroup/cgroup.c Yosry Ahmed 2022-10-11 6773 cgrp = cgroup_v1v2_get_from_file(f); > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6774 fput(f); > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6775 return cgrp; > 1f3fe7ebf6136c3 kernel/cgroup.c Martin KaFai Lau 2016-06-30 6776 } > a6d1ce5951185ee kernel/cgroup/cgroup.c Yosry Ahmed 2022-10-11 6777 > > :::::: The code at line 6765 was first introduced by commit > :::::: 1f3fe7ebf6136c341012db9f554d4caa566fcbaa cgroup: Add cgroup_get_from_fd > > :::::: TO: Martin KaFai Lau > :::::: CC: David S. Miller > > -- > 0-DAY CI Kernel Test Service > https://01.org/lkp