From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: * X-Spam-Status: No, score=1.0 required=5.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by gnuweeb.org (Postfix) with ESMTPS id 7E3317E24D for ; Fri, 30 Dec 2022 18:13:48 +0000 (UTC) Received: by mail-io1-f54.google.com with SMTP id h6so11466849iof.9 for ; Fri, 30 Dec 2022 10:13:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BjjFYrn+Z6BrwQksjCuz3/lydaArAzbP2sbV0KLxPy8=; b=mWRzQXxe8RUoUusL8s7UXjgkyNdieuDrFv05x6QxzvNSU3wA1+Y+72dx5+3Qgybijh scOwzmWeu+vzLy0g1RFPfoleRxFApiuhDKLDlmAgUS83JxwosKF8/kj8HbVdYYqaEhRW ICtT/4J3xu2yetF2G61e/m6gsswNJzkacCT1dK8KvMwLjsm1WwMTdo9NxjeKAUCTKlI8 sLc686QaZ810Hh4o7ExwafbGefDtz249wLl55e+keqY4Avy0KNrTrR382j6+tFan2fEL x6AoYmHFhBRmz6YCmbQPpCgSW0kNY3Opxf+iLXYnnpfwe6kw6RsjrCSlkEbVzC7VY1rZ SGnA== X-Gm-Message-State: AFqh2krHxE03LtGnacgxkEIPvMZbPuEyn8WhYBHzWik0ljqCdN3V/Mlm MkHWstA1rY8qMtu40oYg+0mPb4p17dxg2unN6Kw= X-Google-Smtp-Source: AMrXdXsFDmiFbOwAISGoYvX96GPBHqjsnblzpwinRTNmG/43jaVn4C/GjMuEMo/LrdYQwGIRK6DNTbQ8+wvW98l2lTo= X-Received: by 2002:a5e:c00c:0:b0:6a2:8015:afef with SMTP id u12-20020a5ec00c000000b006a28015afefmr2425943iol.149.1672424027483; Fri, 30 Dec 2022 10:13:47 -0800 (PST) MIME-Version: 1.0 References: <20221223142419.3781410-1-ammar.faizi@intel.com> <20221223142419.3781410-2-ammar.faizi@intel.com> In-Reply-To: <20221223142419.3781410-2-ammar.faizi@intel.com> From: "Rafael J. Wysocki" Date: Fri, 30 Dec 2022 19:13:35 +0100 Message-ID: Subject: Re: [PATCH v1 1/2] ACPI: Silence missing prototype warnings To: Ammar Faizi Cc: Robert Moore , "Rafael J. Wysocki" , Len Brown , Nick Desaulniers , Tom Rix , Nathan Chancellor , Linux ACPI Mailing List , Linux Kernel Mailing List , ACPICA Mailing List , LLVM Mailing List , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" List-Id: On Fri, Dec 23, 2022 at 3:25 PM Ammar Faizi wrote: > > From: Ammar Faizi > > Compiling with clang-16: > > drivers/acpi/acpi_lpit.c:142:6: error: no previous prototype \ > for function 'acpi_init_lpit' [-Werror,-Wmissing-prototypes] > > drivers/acpi/ioapic.c:212:6: error: no previous prototype \ > for function 'pci_ioapic_remove' [-Werror,-Wmissing-prototypes] > > drivers/acpi/ioapic.c:229:5: error: no previous prototype \ > for function 'acpi_ioapic_remove' [-Werror,-Wmissing-prototypes] > > Include "internal.h" to silence them. > > Cc: LLVM Mailing List > Signed-off-by: Ammar Faizi > --- > drivers/acpi/acpi_lpit.c | 1 + > drivers/acpi/ioapic.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/acpi/acpi_lpit.c b/drivers/acpi/acpi_lpit.c > index 50540d4d4948..3843d2576d3f 100644 > --- a/drivers/acpi/acpi_lpit.c > +++ b/drivers/acpi/acpi_lpit.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include "internal.h" > > struct lpit_residency_info { > struct acpi_generic_address gaddr; > diff --git a/drivers/acpi/ioapic.c b/drivers/acpi/ioapic.c > index a690c7b18623..6677955b4a8e 100644 > --- a/drivers/acpi/ioapic.c > +++ b/drivers/acpi/ioapic.c > @@ -24,6 +24,7 @@ > #include > #include > #include > +#include "internal.h" > > struct acpi_pci_ioapic { > acpi_handle root_handle; > -- Applied as 6.3 material, thanks!