From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server-vie001.gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_DBL_BLOCKED_OPENDNS, URIBL_ZEN_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1751316092; bh=1vuHaxefNMfw6O2ANTNqtKlS+BxavuUzTfaqhaxrujk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From: Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date: Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type: Content-Transfer-Encoding; b=AV5kd1Fow0MQTBCSncnPcp4SqdNuttB0/TTytK+fTCPCaMUKl5pBExMWzj3CFgrHH mJW1/DRNVGh3ZT8LpOdRbIsdMDl+IRR37nmDfH0iScy5fnNtGDCLvbmjY6vaS/tNNd 9JcqejCm29mveLYMw5UHyAIqCVG11r1y052VL0gN35NPAAcDWqReYuvyc4w+KcAV3p tnNEn6TSAx+gpmTUFNbHQikOZVEHhRZvHgKR3yFMUjoXZVduFDBFWRBWPBvYAqx1GR JZ0L+ZxC6EXqntlm7KHmscC950f+fNP2kiNhS9j6UBoYojem/VFoADK5bdCxxpedtm r5IeXtb5Wk7KQ== Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 9A8052109A7E for ; Mon, 30 Jun 2025 20:41:32 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-3138e64b42aso5656308a91.0 for ; Mon, 30 Jun 2025 13:41:32 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXXLGKNsGjarsUMukaFlwHM4927SsbuIH4FJ6FEX9nOxKXToohaUJwwFP2tEgVP37xOmxB9@vger.gnuweeb.org X-Gm-Message-State: AOJu0Yyik5FSfxzIBOqIK73A94+KA3/XQyfp5OYJaoZnJ0+doQabrH0/ h0FwY/joN5lSFzuY2sigZ3g6e3Cp2j8yk1+BRkeNC/f99q7uFtTLjufnzNKtuWo4USz1Q0JSIr+ 17xGZJZLsgZzyg/FDTZ2utfE+4UtieW4= X-Google-Smtp-Source: AGHT+IFM/riXBofepRrWM0oi9uou69dBA3d0+YFI/1z/TETZ4JmmB0rFOJc2RB74Kg/1Z2JX9Kv6/LH4iroAX8SVwVI= X-Received: by 2002:a17:90b:5347:b0:311:ba2e:bdc9 with SMTP id 98e67ed59e1d1-318c930f9c3mr21034862a91.27.1751316090679; Mon, 30 Jun 2025 13:41:30 -0700 (PDT) MIME-Version: 1.0 References: <20250630203641.1217131-1-ammarfaizi2@gnuweeb.org> In-Reply-To: <20250630203641.1217131-1-ammarfaizi2@gnuweeb.org> From: Alviro Iskandar Setiawan Date: Tue, 1 Jul 2025 03:41:19 +0700 X-Gmail-Original-Message-ID: X-Gm-Features: Ac12FXwPYc-55eqN8q1QwK0TcG6RzdbEzr4LxvbIb_2cdCYnYRBweIcfPi7DrUw Message-ID: Subject: Re: [PATCH liburing] liburing.h: Only use `IOURINGINLINE` macro for FFI functions To: Ammar Faizi Cc: Jens Axboe , io-uring Mailing List , "GNU/Weeb Mailing List" , Linux Kernel Mailing List , Christian Mazakas Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Tue, Jul 1, 2025 at 3:36=E2=80=AFAM Ammar Faizi wrote: > These 3 inline functions are for liburing internal use, it does not > make much sense to export them: > > uring_ptr_to_u64 > io_uring_cqe_iter_init > io_uring_cqe_iter_next > > Don't use IOURINGINLINE on them. Also, add a comment on the > IOURINGINLINE macro definition explaining when to use IOURINGINLINE > and remind the reader to add the exported function to liburing-ffi.map > if they introduce a function marked with IOURINGINLINE. > > Cc: Christian Mazakas > Cc: Alviro Iskandar Setiawan > Signed-off-by: Ammar Faizi Reviewed-by: Alviro Iskandar Setiawan