Re: [PATCH gwproxy v1 1/3] dnslookup: split common functionality and struct into net.c

[Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>]

On Fri, Aug 1, 2025 at 1:36 AM Ammar Faizi wrote:
> On Fri, Aug 01, 2025 at 01:28:22AM +0700, Alviro Iskandar Setiawan wrote:
> > On Thu, Jul 31, 2025 at 9:01 PM Ammar Faizi wrote:
> > > On Thu, Jul 31, 2025 at 10:07:44AM +0700, Ahmad Gani wrote:
> > > > +int init_addr(const char *addr, struct gwp_sockaddr *addr_st, uint16_t port)
> > >
> > > This is a no-no. We don't need it.
> > >
> > > In gwproxy.c, there is convert_str_to_ssaddr(). It's also better than
> > > your version because with it you can have:
> > >
> > >   ./gwproxy --target google.com:80 --bind localhost:1111
> > >
> > > Not restricted to IP address format, but domain name is also ok.
> >
> > The init_addr() function is used in the subsequent patch within the
> > gw_ares_init() function to transform IP address strings into its
> > binary form. That IP address is expected to be used as the DNS server.
> >
> > I think a variant of convert_str_to_ssaddr() that accepts only an IP
> > address format should be created to handle the task in gw_ares_init(),
> > as domain name resolution is not expected yet at that point.
>
> That's not true. A DNS server IP address can be specificed in a domain
> name format too. For example:
>
>   $ nslookup google.com one.one.one.one
>   Server:               one.one.one.one
>   Address:      1.1.1.1#53
>
>   Non-authoritative answer:
>   Name: google.com
>   Address: 142.250.188.238
>   Name: google.com
>   Address: 2607:f8b0:4007:809::200e
>
> will resolve one.one.one.one first, then it uses the resolved address
> 1.1.1.1 to resolve google.com.

Ah, ic ic. I didn't know that. So it's fine to keep using glibc's
getaddrinfo() to initialize ares?

-- Viro