From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alviro.iskandar@gnuweeb.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	server-vie001.gnuweeb.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_ZEN_BLOCKED_OPENDNS
	autolearn=ham autolearn_force=no version=3.4.6
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org;
	s=new2025; t=1753986002;
	bh=Yr7fevydcj8+wyQ3Xusc/ex/7HEZNuMAu99qCwzPRhk=;
	h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:
	 To:Cc:Content-Type:Content-Transfer-Encoding:Message-ID:Date:From:
	 Reply-To:Subject:To:Cc:In-Reply-To:References:Resent-Date:
	 Resent-From:Resent-To:Resent-Cc:User-Agent:Content-Type:
	 Content-Transfer-Encoding;
	b=wBYRcexFPe/FnBEhSeQaePGieA72i+Owfyi3QLKfn76EhN5xFZmGI188l7cQHMqEL
	 Zb//KNBJwwc7FgWZB0sUTd+50PWbXXQverd+z7hSqVBIXND0P/cAzWxdTpzG7N1f+Q
	 ynJeR0xhjp6xbSGJkdlIPGIooaTtmHEuXntA11ZtuYxuN6An7/oARfCrHQFifcsjm1
	 sV4lYCcck7093nIigb+8scQlLjO0Kt/3RBZZf171PhIK1zApMrzVBqbAD292cKPgF8
	 r3lL3hoeo5sRQb4NbbcAfj6AtZBdvYHIZJYMXCk1hlyVQDqiE9kDTRP7y0V2sP3LM9
	 aBogHOz0S5tCg==
Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176])
	by server-vie001.gnuweeb.org (Postfix) with ESMTPSA id 916003126E82
	for <gwml@vger.gnuweeb.org>; Thu, 31 Jul 2025 18:20:02 +0000 (UTC)
Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-879d2e419b9so808638a12.2
        for <gwml@vger.gnuweeb.org>; Thu, 31 Jul 2025 11:20:02 -0700 (PDT)
X-Forwarded-Encrypted: i=1; AJvYcCW2WU894DpT46BSNhGYPhY66paPIraP+Do4Hiic+43WQUrkElvJ1AVrtfJcXp1ZOBnTKmYb@vger.gnuweeb.org
X-Gm-Message-State: AOJu0YziMzo8GnR5ykCTGvsJP2pewX8nEUZsoaBNdxiP3uIv/b34Iy6X
	yPBDALV5cP0QOfPTa6YO3dwkdcFGyNmpvJ32jHYYZOmbvMCV/oIbG/1rZIIW5GRtPldDXerI4N5
	AtDKQSg9dKmGUs4DaDmfdb/kK6JcC/mk=
X-Google-Smtp-Source: AGHT+IEU0VDO54ZzYUnUIzKsX2EicHEC28MJPzq3WPWHYNXu7wORWzxMV+DSfYpBRyilgYCV1IyoAR5xhHFyVBcG5VE=
X-Received: by 2002:a17:90b:2885:b0:31f:210e:e34a with SMTP id
 98e67ed59e1d1-31f5dd9dcb4mr12292493a91.8.1753986000944; Thu, 31 Jul 2025
 11:20:00 -0700 (PDT)
MIME-Version: 1.0
References: <20250731030856.366368-1-reyuki@gnuweeb.org> <20250731030856.366368-4-reyuki@gnuweeb.org>
In-Reply-To: <20250731030856.366368-4-reyuki@gnuweeb.org>
From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
Date: Fri, 1 Aug 2025 01:19:49 +0700
X-Gmail-Original-Message-ID: <CAOG64qMPmFL-+7OrVv4psmyOt8G-3OZJGa=bQ1a_wuV06WTyng@mail.gmail.com>
X-Gm-Features: Ac12FXxTFxrWU6hfR4Akw8rvDnIeJhccRisgfvSDMzwaWylf8PavZ-bZHMl3Ls8
Message-ID: <CAOG64qMPmFL-+7OrVv4psmyOt8G-3OZJGa=bQ1a_wuV06WTyng@mail.gmail.com>
Subject: Re: [PATCH gwproxy v1 3/3] dnslookup: Initial work for implementation
 of C-ares-like getaddrinfo function
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>, "GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
List-Id: <gwml.vger.gnuweeb.org>

On Thu, Jul 31, 2025 at 10:09=E2=80=AFAM Ahmad Gani wrote:
> +int gw_ares_init(gw_ares_channel_t **channel, struct gw_ares_options *op=
ts)
> +{
> +       gw_ares_channel_t *c;
> +       int ret;
> +
> +       if (!opts->nr_server)
> +               return -EINVAL;
> +
> +       *channel =3D malloc(sizeof(**channel));
> +       if (!*channel)
> +               return -ENOMEM;
> +
> +       c =3D *channel;
> +       c->nr_server =3D opts->nr_server;
> +       c->servers =3D malloc(c->nr_server * sizeof(*c->servers));
> +       if (!c->servers) {
> +               free(*channel);
> +               return -ENOMEM;
> +       }

This can set:

   c =3D malloc(sizeof(*c))

first, then on on success set:

   *channel =3D c;

I don't see a valid reason to fill a dangling pointer if it fails.

-- Viro