public inbox for gwml@vger.gnuweeb.org
 help / color / mirror / Atom feed
From: Alviro Iskandar Setiawan <alviro.iskandar@gnuweeb.org>
To: Ahmad Gani <reyuki@gnuweeb.org>
Cc: Ammar Faizi <ammarfaizi2@gnuweeb.org>,
	"GNU/Weeb Mailing List" <gwml@vger.gnuweeb.org>
Subject: Re: [PATCH gwproxy v1 3/3] dnslookup: Initial work for implementation of C-ares-like getaddrinfo function
Date: Fri, 1 Aug 2025 02:14:57 +0700	[thread overview]
Message-ID: <CAOG64qMZgRUp4i1vY2U0evdobMr4eo_E7imhrCwhPgB9Yg9+Hg@mail.gmail.com> (raw)
In-Reply-To: <20250731030856.366368-4-reyuki@gnuweeb.org>

On Thu, Jul 31, 2025 at 10:09 AM Ahmad Gani wrote:
> +static int resolve_name(int sockfd, const char *name, uint16_t type, uint16_t nport,
> +       struct gw_ares_addrinfo *result, struct gw_addrinfo_node **tail)
> +{
> +       uint8_t send_buff[UDP_MSG_LIMIT];
> +       uint8_t recv_buff[UDP_MSG_LIMIT];
> +       gwdns_query_pkt *query_pkt;
> +       gwdns_answ_data raw_answ;
> +       gwdns_question_part q;
> +       ssize_t buff_len;
> +       int ret;
> [...]
> +attempt_retry:
> +       ret = __sys_send(sockfd, send_buff, buff_len, MSG_NOSIGNAL);
> +       if (ret < 0) {
> +               ret = GW_ARES_INTERNAL_ERR;
> +               return ret;
> +       }
> +
> +       if (ret != buff_len)
> +               goto attempt_retry;

Why is this attempt_retry needed?

-- Viro

  parent reply	other threads:[~2025-07-31 19:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-31  3:07 [PATCH gwproxy v1 0/3] Initial work for DNS lookup implementation Ahmad Gani
2025-07-31  3:07 ` [PATCH gwproxy v1 1/3] dnslookup: split common functionality and struct into net.c Ahmad Gani
2025-07-31 14:01   ` Ammar Faizi
2025-07-31 18:28     ` Alviro Iskandar Setiawan
2025-07-31 18:36       ` Ammar Faizi
2025-07-31 18:42         ` Alviro Iskandar Setiawan
2025-07-31 18:53           ` Ammar Faizi
2025-07-31 19:03             ` Alviro Iskandar Setiawan
2025-07-31  3:07 ` [PATCH gwproxy v1 2/3] dnslookup: Allow only port string number Ahmad Gani
2025-07-31  3:07 ` [PATCH gwproxy v1 3/3] dnslookup: Initial work for implementation of C-ares-like getaddrinfo function Ahmad Gani
2025-07-31 18:19   ` Alviro Iskandar Setiawan
2025-07-31 19:14   ` Alviro Iskandar Setiawan [this message]
2025-08-01  1:51     ` reyuki
2025-08-01 23:32       ` Alviro Iskandar Setiawan
2025-07-31 13:39 ` [PATCH gwproxy v1 0/3] Initial work for DNS lookup implementation Ammar Faizi
2025-08-01  1:49   ` reyuki
2025-08-01  2:19     ` Ammar Faizi
2025-08-05  6:28       ` reyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOG64qMZgRUp4i1vY2U0evdobMr4eo_E7imhrCwhPgB9Yg9+Hg@mail.gmail.com \
    --to=alviro.iskandar@gnuweeb.org \
    --cc=ammarfaizi2@gnuweeb.org \
    --cc=gwml@vger.gnuweeb.org \
    --cc=reyuki@gnuweeb.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox