public inbox for [email protected]
 help / color / mirror / Atom feed
From: Alviro Iskandar Setiawan <[email protected]>
To: Ammar Faizi <[email protected]>
Cc: Muhammad Rizki <[email protected]>,
	Kanna Scarlet <[email protected]>,
	 "GNU/Weeb Mailing List" <[email protected]>
Subject: Re: [RFC PATCH v1 1/2] chnet: Prepare global struct ch_thpool array
Date: Mon, 29 Aug 2022 11:21:10 +0700	[thread overview]
Message-ID: <CAOG64qMbEXv_6kJ4=78HvU+_Hhzs=6UXPnj=cYJitgr4ta+aOw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>

On Mon, Aug 29, 2022 at 8:11 AM Ammar Faizi wrote:
> +       g_max_ch_thpool = std::thread::hardware_concurrency() - 1;
> +       if (g_max_ch_thpool < 1)
> +               g_max_ch_thpool = 1;

this is wrong, std::thread::hardware_concurrency() should be treated
as a hint, if this happens to return 0, then the sub with 1 will make
it ~0, that will definitely hit ENOMEM.

this should be:

        g_max_ch_thpool = std::thread::hardware_concurrency();
        if (g_max_ch_thpool <= 1)
                g_max_ch_thpool = 1;
        else
                g_max_ch_thpool -= 1;

tq

-- Viro

  reply	other threads:[~2022-08-29  4:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29  1:11 [RFC PATCH v1 0/2] Fixed number of chromium workers Ammar Faizi
2022-08-29  1:11 ` [RFC PATCH v1 1/2] chnet: Prepare global struct ch_thpool array Ammar Faizi
2022-08-29  4:21   ` Alviro Iskandar Setiawan [this message]
2022-08-29  4:47     ` Ammar Nofan Faizi
2022-08-29  1:11 ` [RFC PATCH v1 2/2] chnet: Implement `get_thread()` and `put_thread()` function Ammar Faizi
2022-08-29  4:41   ` Alviro Iskandar Setiawan
2022-08-29  4:54     ` Ammar Nofan Faizi
2022-08-29  5:17       ` Alviro Iskandar Setiawan
2022-08-29  5:24         ` Alviro Iskandar Setiawan
2022-08-29  5:29           ` Ammar Nofan Faizi
2022-08-29  5:38             ` Alviro Iskandar Setiawan
2022-08-29  5:48               ` Ammar Nofan Faizi
2022-08-29  6:01                 ` Alviro Iskandar Setiawan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOG64qMbEXv_6kJ4=78HvU+_Hhzs=6UXPnj=cYJitgr4ta+aOw@mail.gmail.com' \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    [email protected] \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox