From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on gnuweeb.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,URIBL_BLOCKED, URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=3.4.6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gnuweeb.org; s=default; t=1702987556; bh=26lrHcQfnoq0P3eDGcD/6wC6C+pTFV1KRGECV4Wp3dk=; h=References:In-Reply-To:From:Date:Subject:To:Cc; b=XrZKKm2sK/dqby8SVweE+b0JVyN/S/wf/IHyluSOg7Fts0XfB2zF+Rh3BOrPoyiVK 1m0VYPfJtRfz48g0ZvQyOeacjkjSTMoJ4BXEpJ2jBD0FXapLCxw9VgRy7bLvmpeRHS ppuS5BRjYZPbgZicMnoO2ISsSluiZyiNd3EP/IVFYq8p1uLmKKpO0pHC3V8THSWrRI 7rGjhD8XaaNi42YrlG4z7xHDm8pZOhwTwZeIJOuHi9xVdRM199nmXvgxJxwFsMN8Pl haRRch/SJWV5SObqPU0MMcBXAcCOT65K4LC/vPFPMUsYcPMVdEHCFAo2908scZe0Gy Yol6AMCbuWuvQ== Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by gnuweeb.org (Postfix) with ESMTPSA id A2F6B24C1A4 for ; Tue, 19 Dec 2023 19:05:56 +0700 (WIB) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1d3c1a0d91eso9841765ad.2 for ; Tue, 19 Dec 2023 04:05:56 -0800 (PST) X-Gm-Message-State: AOJu0YzG0pIRgljsrympbPAa5Ds+6OjUAVWTia4YVCTT1c9byxlLJquU R05m0v8aQMTgNYalmLEoFMeOusfpSkQYE0pYEzM= X-Google-Smtp-Source: AGHT+IHDs/Fo/z4xwpOWfja653H002HMKNwLfbTm+78Jr7DOFHnjl0FMk4VXluS/Brsvlus5sGjIjlqu6pfRRsY+7qk= X-Received: by 2002:a17:902:d486:b0:1d3:65b0:8399 with SMTP id c6-20020a170902d48600b001d365b08399mr5476484plg.59.1702987555969; Tue, 19 Dec 2023 04:05:55 -0800 (PST) MIME-Version: 1.0 References: <20231219115423.222134-1-ammarfaizi2@gnuweeb.org> <20231219115423.222134-3-ammarfaizi2@gnuweeb.org> In-Reply-To: <20231219115423.222134-3-ammarfaizi2@gnuweeb.org> From: Alviro Iskandar Setiawan Date: Tue, 19 Dec 2023 19:05:44 +0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH liburing v1 2/2] t/no-mmap-inval: Replace `valloc()` with `t_posix_memalign()` To: Ammar Faizi Cc: Jens Axboe , Michael William Jonathan , io-uring Mailing List , Linux Kernel Mailing List , "GNU/Weeb Mailing List" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: On Tue, Dec 19, 2023 at 6:54=E2=80=AFPM Ammar Faizi wrote: > Address the limitations of valloc(). This function, which is primarily > used for allocating page-aligned memory, is not only absent in some > systems but is also marked as obsolete according to the `man 3 valloc`. > > Replace valloc() with t_posix_memalign() to fix the following build > error: > > no-mmap-inval.c:28:56: warning: call to undeclared function 'valloc'; I= SO C99 and \ > later do not support implicit function declarations [-Wimplicit-functio= n-declaration] > p.cq_off.user_addr =3D (unsigned long long) (uintptr_t) valloc(= 8192); > ^ > 1 warning generated. > > ld.lld: error: undefined symbol: valloc > >>> referenced by no-mmap-inval.c:28 > >>> /tmp/no-mmap-inval-ea16a2.o:(main) > >>> did you mean: calloc > >>> defined in: /system/lib64/libc.so > clang-15: error: linker command failed with exit code 1 (use -v to see = invocation) > make[1]: *** [Makefile:239: no-mmap-inval.t] Error 1 > > Signed-off-by: Ammar Faizi Reviewed-by: Alviro Iskandar Setiawan -- Viro